-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[es] Webassembly localization es #3383
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8e9f625
to
c17271c
Compare
Muchas gracias @eddymdz por tu contribución, dejo una par de observaciones y sugerencias. Por otra parte, es necesario agregar un par de palabras en orden alfabético a la lista del diccionario para evitar estos errores en el CI. Avísame si necesitas ayuda. |
…ndex.md (cncf#3357) Signed-off-by: Andrés García <[email protected]> Signed-off-by: Andres Garcia <[email protected]> Co-authored-by: Victor Morales <[email protected]> Signed-off-by: Eduardo <[email protected]>
Signed-off-by: Eduardo <[email protected]>
…-guide/index.md (cncf#3357)" This reverts commit c6321fe. Signed-off-by: Eduardo <[email protected]>
Signed-off-by: Eduardo <[email protected]>
c798533
to
31043c3
Compare
Muchísimas gracias @electrocucaracha , ya sub´í alguno de los cambios que me marcaste e hice otros :) |
Solo falta agregar en este archivo las siguientes palabras
|
f24dd51
to
8f26839
Compare
Signed-off-by: Eduardo <[email protected]>
8f26839
to
bf047a8
Compare
Signed-off-by: Eduardo <[email protected]>
Gracias! ya he agregado las palabras, disculpa la demora |
Creo que me falto agregar a la lista |
Qué curioso, no tengo esa palabra en mi en mi texto :/ |
Signed-off-by: Eduardo <[email protected]>
Parece ser que esa palabra fue agregada hace 6 meses por este PR, de casualidad utilizaste los ultimos cambios del branch |
Ah claro, yo más temprano tuve un conflicto e hice un merge desde dev-es efectivamente |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddymdz solo un par de observaciones para que quede alineado con la versión en ingles
Co-authored-by: Victor Morales <[email protected]> Signed-off-by: Eduardo Méndez <[email protected]>
Co-authored-by: Victor Morales <[email protected]> Signed-off-by: Eduardo Méndez <[email protected]>
Co-authored-by: Victor Morales <[email protected]> Signed-off-by: Eduardo Méndez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammatical suggestions.
Co-authored-by: Rodolfo Martínez Vega <[email protected]> Signed-off-by: Eduardo Méndez <[email protected]>
Co-authored-by: Rodolfo Martínez Vega <[email protected]> Signed-off-by: Eduardo Méndez <[email protected]>
Describe your changes
I created a new file name webassembly.md in Spanish in the content/es to match the English file in content/en
Related issue number or link
resolves #3288
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.