Don't store search increments in the browser history #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Abraham <[email protected]>
cjyabraham
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jihoon-seo
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Preview: https://deploy-preview-3207--cncfglossary.netlify.app/search/?q=cloud
In preview, it works as intended. LGTM!
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you refine your search term, each additional edit get stored in the browser history so that clicking Back will only take you to the previous edit. This eliminates that storage so that clicking Back will take the user to the previous page.