Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Merge dev-ja into main @v4 #3019

Merged
merged 20 commits into from
Apr 17, 2024
Merged

[ja] Merge dev-ja into main @v4 #3019

merged 20 commits into from
Apr 17, 2024

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Mar 28, 2024

Describe your changes

Merge dev-ja into main to release the Japanese localization v4!!

Terms to be added

The following modifications/updates are included

Related issue number or link (ex: resolves #issue-number)

No issue related to this PR

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 400a724
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/661e66f22d953500084b06b7
😎 Deploy Preview https://deploy-preview-3019--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/ja for Japanese label Mar 28, 2024
t-katsumura and others added 15 commits March 30, 2024 00:03
Signed-off-by: Junya Okabe <[email protected]>
Signed-off-by: Junya Okabe <[email protected]>
Signed-off-by: t-katsumura <[email protected]>
Signed-off-by: t-katsumura <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
Signed-off-by: shinji <[email protected]>
Signed-off-by: shinjichan <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
[ja] Merge `main` into `dev-ja` to sync-up
@jihoon-seo jihoon-seo added the maintainers Use this label if PR requires maintainers to take action label Apr 16, 2024
t-katsumura and others added 2 commits April 16, 2024 20:03
Signed-off-by: t-katsumura <[email protected]>
Signed-off-by: t-katsumura <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Signed-off-by: Kazunori Otani <[email protected]>
Co-authored-by: Junya Okabe <[email protected]>
@Okabe-Junya
Copy link
Collaborator Author

Okabe-Junya commented Apr 16, 2024

@naonishijima @kaitoii11 @inductor @yuichi-nakamura
@seokho-son @jihoon-seo @iamNoah1 @nate-double-u

We are ready to merge this PR!! Fantastic news, Our Japanese l10n team has translated all the words!! Thank you for all of you!!

Acknowledgements

This PR includes contributions by @t-katsumura @katzchang @shinj05 @bashi8128, thank you!!

@Okabe-Junya Okabe-Junya marked this pull request as ready for review April 16, 2024 13:58
@Okabe-Junya Okabe-Junya changed the title [WIP] [ja] Merge dev-ja into main @v4 [ja] Merge dev-ja into main @v4 Apr 16, 2024
Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work folks :) thanks a lot

lgtm

Only thing I am a bit concerned is the DCO. Please make sure for future commits to have them all pass DCO.

@seokho-son
Copy link
Collaborator

Thanks!! on be half of the Japanese team, let me approve and merge this PR.

@seokho-son seokho-son merged commit dcc9f04 into main Apr 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants