Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Merge dev-ja into main (for the third Japanese localization live version) #2969

Merged
merged 14 commits into from
Mar 21, 2024

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Feb 28, 2024

Describe your changes

Merge dev-ja into main to release the Japanese localization v3!!

Terms to be added

The following modifications/updates are included

Related issue number or link (ex: resolves #issue-number)

No issue related to this PR

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@github-actions github-actions bot added the lang/ja for Japanese label Feb 28, 2024
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 04080cc
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65fbcc3e06014400089b2bb0
😎 Deploy Preview https://deploy-preview-2969--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya Okabe-Junya self-assigned this Feb 28, 2024
@Okabe-Junya Okabe-Junya changed the title [WIP] [ja] Merge dev-ja into main (for the third Japanese localization live version) [ja] Merge dev-ja into main (for the third Japanese localization live version) Mar 21, 2024
@Okabe-Junya Okabe-Junya marked this pull request as ready for review March 21, 2024 01:05
@Okabe-Junya
Copy link
Collaborator Author

Okabe-Junya commented Mar 21, 2024

Hi @kaitoii11 @naonishijima @seokho-son @jihoon-seo !!

I think Japanese Localization v3 is now ready for merge. WDYT? Before merging this pr, please take a look #2969 to sync up. thank you :)

acknowledgments

Thank you for all contributions @shizhenhu @bashi8128 @kujiraitakahiro @t-katsumura !! Your contributions will be released soon!!

@Okabe-Junya Okabe-Junya added the maintainers Use this label if PR requires maintainers to take action label Mar 21, 2024
t-katsumura and others added 2 commits March 21, 2024 10:14
[ja] Merge `main` into `dev-ja` to sync-up
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seokho-son seokho-son merged commit 163f1cf into main Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants