Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EN] update Ingress #2696

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[EN] update Ingress #2696

merged 1 commit into from
Dec 12, 2023

Conversation

abhayporwals
Copy link
Contributor

Updated the ingress.md file as required.

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 36ab128
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65747dfc12b459000906de0b
😎 Deploy Preview https://deploy-preview-2696--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nate-double-u nate-double-u changed the title updated status to completed [EN] update Ingress Dec 9, 2023
nate-double-u
nate-double-u approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @professorabhay, /lgtm

@nate-double-u nate-double-u added lang/en for English update term Updates to existing terms labels Dec 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

seokho-son
seokho-son approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm.

@seokho-son seokho-son merged commit 502f242 into cncf:main Dec 12, 2023
@abhayporwals abhayporwals deleted the ingress-en-update branch January 8, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@seokho-son seokho-son seokho-son approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1 iamNoah1 is a code owner

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo jihoon-seo is a code owner

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
lang/en for English update term Updates to existing terms
Projects
CNCF glossary definition review board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update term] Ingress for En
3 participants
@abhayporwals @nate-double-u @seokho-son