Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] add WebAssembly #2117

Merged
merged 10 commits into from
Jul 5, 2024
Merged

[EN] add WebAssembly #2117

merged 10 commits into from
Jul 5, 2024

Conversation

arunkarthicknm
Copy link
Contributor

This resolves #1942

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Arun Karthick N M <[email protected]>
@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 56f0b64
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/668776b04cfc8e00082f7be9
😎 Deploy Preview https://deploy-preview-2117--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label Jun 6, 2023
@arunkarthicknm
Copy link
Contributor Author

Is it fine? @iamNoah1

@arunkarthicknm
Copy link
Contributor Author

@CathPag
Copy link
Collaborator

CathPag commented Jun 11, 2023

Thanks for your contribution, @arunkarthicknm. We are currently working our way through our backlog. This is on our to-do list, but there are a few terms that need to be reviewed before yours. Thanks for your patience!

@arunkarthicknm
Copy link
Contributor Author

Sure @CathPag

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arunkarthicknm
Thank you for the contribution. Before reviewers start to review its content, please check the following comments. :)

@nate-double-u nate-double-u self-requested a review June 12, 2023 19:17
CathPag and others added 2 commits June 16, 2023 09:50
Co-authored-by: Seokho Son <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
@nate-double-u nate-double-u changed the title Added WebAssembly [En] Add WebAssembly Jun 19, 2023
@nate-double-u nate-double-u changed the title [En] Add WebAssembly [EN] add WebAssembly Jun 19, 2023
@nate-double-u nate-double-u self-assigned this Jun 19, 2023
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @arunkarthicknm, some thoughts:

Comment on lines 8 to 11
## What it is

WebAssembly (often abbreviated as Wasm) is a binary instruction format designed as a portable target for compiling high-level languages like C, C++, Rust, and others, enabling deployment on the web for client-side and server-side applications.
It is a low-level bytecode format that can be executed in a virtual machine, typically integrated into web browsers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to mention that Wasm is not just for web applications—it's useful in other spaces too, like IoT, Edge, Cloud, etc. It's a universal runtime, and could probably be used on any platform.

I'd also suggest linking to the virtual machine definition page.

Comment on lines 13 to 16
## Problem it addresses
Traditional web applications are primarily built using JavaScript, which is an interpreted language.
While JavaScript has improved over the years, it still faces performance limitations when executing computationally intensive tasks.
With JavaScript, developers often need to rewrite their code to make it work across different platforms and environments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section focuses a lot on JavaScript, and brings up valid issues, but Wasm is something that works along side it, not necessarily replacing it (and it's not that JavaScript needs to be rewritten, I think it's more that the browser environment is inconsistent). I tend to think of Wasm for performance centric stuff, and JavaScript for more dynamic tasks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder about the rewriting bit here -- thinking more on it, one of the things that WASM helps with is not having to rewrite legacy code either -- if you have some old C code that is doing the job, it can potentially be used without rewriting on the web now too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I question the accuracy in comparing WASM to javascript at all. I would also remove this.

This opens up new possibilities and allows developers to reuse existing codebases and libraries.
Also, WebAssembly modules can run consistently across different browsers, operating systems, and devices, reducing the need for platform-specific code.

Overall, WebAssembly addresses performance limitations, language restrictions, code portability, security concerns, code size, and loading time issues, providing a more robust and flexible environment for web application development.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we mention security here, it might be worth noting that WebAssembly has a sandboxed execution environment, meaning it isolates the WebAssembly program from the system it's running on, which can provide some protection against malicious code. This may not be the best place to bring it up since it's the concluding paragraph though.

@nate-double-u nate-double-u removed their assignment Jun 20, 2023
@nate-double-u nate-double-u self-assigned this Jun 27, 2023
@nate-double-u
Copy link
Member

Hi @arunkarthicknm, it's been a couple of weeks since we've seen any activity on this PR, and I wanted to check-in. Please don't hesitate to ask if you have any questions or need further clarification on any of the points I've raised. We're here to help.

@nate-double-u nate-double-u removed their assignment Jan 25, 2024
@hlipsig
Copy link
Contributor

hlipsig commented Jan 25, 2024

Agreed with @nate-double-u on the suggested changes. If no objections I'll noodle on some recommended wording for the content.

@nate-double-u
Copy link
Member

No objections, please noodle 🙂

@iamNoah1
Copy link
Collaborator

iamNoah1 commented Mar 8, 2024

What is the status here? @nate-double-u

@nate-double-u
Copy link
Member

nate-double-u commented Mar 8, 2024

@hlipsig, you were working on a review, but had some questions around how best to provide the feedback. Did we land on a best practice?

@iamNoah1
Copy link
Collaborator

iamNoah1 commented Apr 8, 2024

@nate-double-u @hlipsig my suggestion would be to add suggestions via the suggestion feature so that they can easily be added (committed) through the web ui. And also as the author is not responsive anymore we should just go on and make the suggested changes ourselves. What you think @nate-double-u, wanna take over? Or @arunkarthicknm wants to follow up?

@nate-double-u
Copy link
Member

I'm happy to take it over. @hlipsig, I'm also happy to work with you to get your suggestions in, I'd hate for you to have done work that didn't get considered 🙂

Copy link
Contributor

@hlipsig hlipsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get my thoughts on security together, but here was my first pass at improvements.

Comment on lines 13 to 16
## Problem it addresses
Traditional web applications are primarily built using JavaScript, which is an interpreted language.
While JavaScript has improved over the years, it still faces performance limitations when executing computationally intensive tasks.
With JavaScript, developers often need to rewrite their code to make it work across different platforms and environments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I question the accuracy in comparing WASM to javascript at all. I would also remove this.

iamNoah1 and others added 4 commits July 3, 2024 12:22
Co-authored-by: Hilliary Lipsig <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Hilliary Lipsig <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Hilliary Lipsig <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
@nate-double-u nate-double-u requested a review from castrojo as a code owner July 3, 2024 23:03
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your patience @arunkarthicknm, and to all the reviewers!

Copy link

github-actions bot commented Jul 4, 2024

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

1 similar comment
Copy link

github-actions bot commented Jul 4, 2024

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -0,0 +1,23 @@
---
title: WebAssembly
status: Feedback Appreciated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status: Feedback Appreciated
status: Completed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great work! Let me update the tag to make the term live.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seokho-son seokho-son merged commit c53b99b into cncf:main Jul 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[New term] WebAssembly
8 participants