Added additional support for git documentation sources #71
+61
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some improvements for the handling of mkdocs materials when using git as a source for the docs. The changes are summarized as follows:
Note:
Because this PR configures git to use the store git credential helper, but the config file is read-only, we see this error in the init container logs every time git tries to write the creds:
fatal: unable to get credential storage lock in 1000 ms: Read-only file system
This error does not impact the functionality because the credentials did not actually change and the read of the credentials works properly. This could be fixed by using a custom git credential helper, but that would require some additional development. Is it ok to leave the current implementation given that error in the logs or should we fix it?