fix: broken epix_merge operations #174
Merged
+92
−556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
commented
Mar 1, 2025
| @@ -1,489 +0,0 @@ | |||
| --- | |||
| title: Evaluation of Hospitalization Forecasters 2024-2025 | |||
There was a problem hiding this comment.
This is an old version of a comparison notebook that now lives in /scripts/reports. Removing this minimize maintenance surface.
dshemetov
commented
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, joined_archive_data was completely incorrect after epix_merge. I dug into it with Logan and found that dplyr operations are extremely dangerous when mixed with data.table. The fix is to make sure to call
as.data.frame()before callingas_epi_archive(), any time you work with dplyr ops on an archive's DT. There were also a couple other scoring and plotting things that needed to be fixed.TODO:
address #173