merge dev -> main #617
Merged
merge dev -> main #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asets data (#577) * stop reexporting epidatasets data * import epidatasets in package file * version * docs: document (GHA) --------- Co-authored-by: nmdefries <[email protected]>
Complete partial update to author info
to ease epipredict transition.
* Produce error rather than default selection when user provides a tidyselection in ... but it selects zero columns. * Change time_within_x_latest to take `values` as a vector * Use `.data` instead of `pick` etc. in some places
So it is not misinterpreted as "the amount of time that it has been near the latest".
and avoid unnecessary `abs()`
* This may fix some behaviors and emit more sensible error messages on yearmonths given yearmonth-incompatible settings. * This should express time differences for weekly data in terms of weeks, and may emit errors given weekly-"incompatible" settings. * This appears to be computationally faster (vs. `as.integer(version) - as.integer(time_value)`).
It's probably best to immediately ungroup after performing grouped operations in our documentation, as leaving things grouped accidentally is a source of errors. Sometime we should consider an overhaul to use `by =` and `.by =` where appropriate (sorting effects not needed) and available (not all operations support this syntax yet). There were already 0s in the example data, so "highlight" with words the effects of completion + note one potential surprise in other applications.
- Note `...` optional in args of slide comp fn. - Push toward computations returning tibbles rather than vanilla data.frames. - Highlight `na.rm = TRUE`'s operation (not the only type of 7dsum/7dav), mention we also show sum. - Immediately ungroup output + save a line using new autogroup-ungroup behavior of epi_slide_opt&co.
So that naming, docs, and implementation all match.
So we can crossref in other internal roxygen without CHECK warning.
…d_case_death_rates_extended` as-of date (#604) * change as-of date in vignette example * bump version
Tweak archive construction and compactification tolerance interfaces
cyclocomp_linter is no longer part of the defaults, so we don't need to config to disable it it: https://lintr.r-lib.org/news/index.html#deprecations--breaking-changes-development-version Keeping the config around was generating warnings in CI, so remove it.
Lint + lint config updates for 0.11
perf: Use `new_tibble()` in the common no-`...` case. doc: don't @inheritParams `...` when we wanted @inheritDotParams; but favor just mentioning forwarding over the latter since no `...` is the common case. doc: mention other-attribute dropping.
We can remove some level of call nesting by using existing new_tibble(vec_recycle_common()) rather than vec_cbind() to incorporate the group_key. (While we weren't triggering this behavior, `vec_cbind()` has some ptype rules that are probably not what we want if `epi_df`s were to be involved, so hopefully this will also prevent future re-use in a situation where that might have been the case.)
Minor performance improvements and enabling fixes
brookslogan
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Since we're not doing releases yet, nothing else needs to be done, pkg_install still points to dev by default, but the site documentation will be updated.
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch