Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix growth rate #437

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Hotfix growth rate #437

merged 8 commits into from
Feb 14, 2025

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

@dajmcdon dajmcdon requested a review from brookslogan February 11, 2025 22:40
@dajmcdon dajmcdon mentioned this pull request Feb 11, 2025
4 tasks
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just running into this over on #431; I'm surprised the tests for step_growth_rate were passing before explicitly specifying which argument is x and which is y for growth_rate.

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should work. I'm getting test failures locally from test-bake-method.R and test-population_scaling.R but they appear to be unrelated.

@dajmcdon dajmcdon merged commit ba0a94f into dev Feb 14, 2025
2 checks passed
@dshemetov dshemetov deleted the hotfix-growth_rate branch February 20, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants