Skip to content

Add linting to CI for subset of indicators #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Add linting to CI for subset of indicators #489

merged 4 commits into from
Nov 11, 2020

Conversation

chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Nov 10, 2020

Description

Add linting for tests which currently pass linting. Decided that waiting for get all of them fixed in #452 could take a few days and may lead to other lint breaking changes getting merged in the meantime, so might as well enable the ones that work.

Changelog

  • Enable linting with a conditional statement to only run on the indicators which currently pass.
  • Fixed a whitespace on google symptoms to get it to pass

Fixes

  • n/a

add quotes

try just google symptoms

move statement into braces

readd skips

fix braces

fix quoting
@chinandrew chinandrew changed the title CI lint test Add linting to CI for subset of indicators Nov 10, 2020
@chinandrew chinandrew requested a review from krivard November 10, 2020 22:43
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit 342df53 into main Nov 11, 2020
@krivard krivard deleted the add-some-linting branch November 11, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants