Refactor claims_hosp to use new geomapper functions #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariajahja
requested changes
Oct 17, 2020
There was a problem hiding this comment.
The original code is broken in main due to the changes introduced in GeoMapper. I can run a comparison off commit 64eb227 (when the package was originally introduced, and before GeoMapper changes). The results line up for state, hrr, and county, but msa has an error.
mariajahja
approved these changes
Oct 17, 2020
krivard
approved these changes
Oct 20, 2020
|
I don't believe this indicator makes any use of the GeoMapper population functions. Is that correct? If we use population data here, I should block this merge until we fix #325. |
|
Yes, this indicator does not use population. So there shouldn't be any problem merging. |
dshemetov
reviewed
Oct 20, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #306
Summary of changes:
Couple things to note here:
The previous functions, e.g.
county_to_state(), don't exist in the GeoMapper package.convert_fips_to_state_id()in the GeoMapper package which contain the arguments called by this code, so maybe they used to be namedcounty_to_state()but were renamed later. However, if you use these functions, the code doesn't work due to a non-unique multi-index.After switching to the new functions all tests pass, but I can't verify against previous behaviour since the original code didn't run.