Skip to content

Automate quidel patch #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Automate quidel patch #2077

wants to merge 13 commits into from

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Nov 7, 2024

Description

automate patching for quidel and change backfill merge cadence from 28 days to 1 month worth of data

Associated Issue(s)

@aysim319 aysim319 marked this pull request as ready for review November 7, 2024 22:35
@nmdefries nmdefries self-requested a review November 27, 2024 17:29
@nmdefries
Copy link
Contributor

Do any comments from #2043 reviews apply here?

@nmdefries
Copy link
Contributor

Tests are actually running now, but not passing. Linting is passing.

@nmdefries
Copy link
Contributor

Running tests locally gives me a different error than in CI
nat_local_test_output.txt

@aysim319
Copy link
Contributor Author

previously I was planning on changing the file naming format to yyyymm for the backfill file, but the migrations that would require to accept the new format seemed excessive for not much gain. the claims hospital code has been updated to reflect that change and working with the previous file name format. I'm going and delete the branch and start it from scratch

@aysim319 aysim319 closed this Jan 24, 2025
@aysim319 aysim319 deleted the automate-quidel-patch branch January 24, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants