optimize: speed up stat gen by factor x15 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlSchlo
changed the title
AlSchlo
changed the title
| Self::generate_partial_stats(&comb, mgs, hlls, null_cnts); | ||
| Ok(local_stats) | ||
| } | ||
| Err(_) => todo!(), // TODO(Alexis): Could not satisfy the type checker otherwise, but never happens! |
There was a problem hiding this comment.
If it never happens you can panic!() here with a description in the panic for why it never happens
| @@ -410,7 +414,7 @@ impl DatafusionDBMS { | |||
| &mut self, | |||
| job_kit_config: &JobKitConfig, | |||
| ) -> anyhow::Result<DataFusionBaseTableStats> { | |||
There was a problem hiding this comment.
If you're modifying get_job_stats() you should also modify get_tpch_stats() in the same way. In the future we can think about creating a trait called BenchmarkKit and making a generic function that works with any object of that trait. However, for now unfortunately there's some copied code here.
AlSchlo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the stat generation faster using Rayon's thread pool.
Various improvements, such as;
This takes 30s for JOB 1D stats on my computer, vs 7:30min before.
Postgres takes 1:30min loading, and 22s for the stat gen. So we beat it, depending on how we view it.
On "real" datacenter hardware (i.e. 512 cores), we would crush it, we'll test that soon.
Finally coming together :-)