Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to load after scripts from local filesystem #600

Merged
merged 11 commits into from
Feb 14, 2025

Conversation

bpkroth
Copy link
Collaborator

@bpkroth bpkroth commented Feb 13, 2025

Still fallsback to loading from resource stream when file is not found.

So far logging is only done to the debug stream.

Quick (hackish) fix to close #595

  • Add unit test

@bpkroth
Copy link
Collaborator Author

bpkroth commented Feb 13, 2025

@eujing wanna try this out too?

@bpkroth
Copy link
Collaborator Author

bpkroth commented Feb 13, 2025

note: this is basically what's done for the ddlpath override already

Copy link

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bpkroth bpkroth mentioned this pull request Feb 14, 2025
@eujing
Copy link

eujing commented Feb 14, 2025

@eujing wanna try this out too?

Can confirm, afterload is now working with a .sql script from the filesystem with these changes!

@bpkroth bpkroth merged commit 9834ead into cmu-db:main Feb 14, 2025
138 checks passed
@bpkroth bpkroth deleted the allow-referencing-external-sql-scripts branch February 14, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The XML option afterload only works with packaged scripts
3 participants