Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Changed INSERT statements of templated benchmarks #447

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix: Changed INSERT statements of templated benchmarks #447

merged 1 commit into from
Jan 17, 2024

Conversation

ETHenzlere
Copy link
Contributor

@ETHenzlere ETHenzlere commented Jan 5, 2024 •
edited
Loading

INSERT query was not working due to duplicate primary keys

Simple solutions on the query did not work for all systems
(For example INSERT IGNORE, INSERT -- IF NOT EXISTS).

For now I changed the table of the insert to one that does not have a primary key.

This PR tries to solve #428

@ETHenzlere ETHenzlere marked this pull request as ready for review January 5, 2024 10:42
bpkroth
bpkroth approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bpkroth bpkroth merged commit febe379 into cmu-db:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ETHenzlere @bpkroth