Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives overhaul pt3 #719

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

BonniePandora
Copy link
Contributor

@BonniePandora BonniePandora commented Jan 28, 2025

About the pull request

Adjusts the M5 RPG HE & AP rockets to no longer be PvP-gimped. The HE is a wide area menace, the AP is much much more powerful, but still eclipsed by the SADAR's rocket in terms of straight-up slap damage. All rockets have had their max range upped to 11 tiles.
The M5's recieved an in-built (limited distance) x2 miniscope as per it's sprite, meaning it can reach out to 11 tiles away
The UPP rifle-mounted GL is tweaked, now using the underbarrel slot (you whiny gits) and it's ammunition is now more powerful to justify it's single-shot nature.
Added a long-lasting smoke shell for the mortar, also included in the GM fire support menu now.
Non-lethal smoke grenade clouds and WP-based smoke clouds now have a difference in colour. Avoid the lighter-coloured stuff.
The M108 and M51A have been adjusted, the former being buffed and the latter just having it's detonation function stuff changed about.

Explain why it's good for the game

Making weapon systems effective and fun to use = good
Smoke mortar shell was requested, delivered

Testing Photographs and Procedure

Tested locally, works as intended

Changelog

🆑
add: Smoke shell for the mortar
qol: M5 RPG now has built-in limited view-boost miniscope
qol: Type 71's GL module now uses the underbarrel slot, so the whiners can wheesht
qol: WP smoke and normal smoke have differing shades
qol: The M51A BFAB now 'detonates' on impact, giving a message about it jumping into the air before actually exploding
balance: M5 RPG rockets adjusted in damage values & effect on target
balance: UPP 40mm grenade rounds adjusted to make their single-shot nature worthwhile
balance: M108 grenades are now viable to use in combat, rather than being purely utility
admin: Smoke shell added to GM fire support menu
/:cl:

Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 14 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Feb 14, 2025
Groundwork for gear-presets to come with filled or partially filled UGLs. Once this is merged, UA armed forces will be updated to incorporate this in it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant