Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes base area lighting from the dropships. #651

Closed
wants to merge 4 commits into from

Conversation

Ediblebomb
Copy link
Contributor

About the pull request

Base area lighting in a dropship with a closed roof and lights on the map doesn't really have a reason to exist, this also adds a light to the cockpit so it's not pitch black in there.

Explain why it's good for the game

Base area lighting can look pretty silly (see below image), and the dropships already have lights mapped.

Testing Photographs and Procedure

Screenshots & Videos ![image](https://github.com/user-attachments/assets/8c511c35-e86a-4cf7-900d-ad1d982898f5) ![image](https://github.com/user-attachments/assets/ed5b2334-bab1-449e-8238-f15cead54cc0)

Changelog

🆑 Ediblebomb
maptweak: Dropships no longer have base area lighting.
/:cl:

@Ediblebomb
Copy link
Contributor Author

aaaaaaaaaaaaand the images are bugged. great. perfect.

@Ediblebomb
Copy link
Contributor Author

linters whhhhhhhhhyyyyyyyy

@Ediblebomb
Copy link
Contributor Author

nevermind I'm stupid

@harryob
Copy link
Member

harryob commented Jan 5, 2025

this exists because they get fullbright in transit anyway and it looks pretty dumb toggling between softer ambient lights to harsh lights for no reason when it launches

@Ediblebomb
Copy link
Contributor Author

Ediblebomb commented Jan 5, 2025

this exists because they get fullbright in transit anyway and it looks pretty dumb toggling between softer ambient lights to harsh lights for no reason when it launches

It doesn't look too bad to me. The dropships have enough lights that there aren't really shadows anywhere, though the soft shadows on the walls disappearing does look a little odd, and the cockpit light being red is... bad, I'll probably change it.

@Warfan1815
Copy link
Contributor

this exists because they get fullbright in transit anyway and it looks pretty dumb toggling between softer ambient lights to harsh lights for no reason when it launches

It doesn't look too bad to me. The dropships have enough lights that there aren't really shadows anywhere, though the soft shadows on the walls disappearing does look a little odd, and the cockpit light being red is... bad, I'll probably change it.

This problem has already been, more or less, fixed in #545 (which is nearing merge) . I can't remember specifically how I did it, but it looks alright transitioning between space and ground.

@Ediblebomb
Copy link
Contributor Author

this exists because they get fullbright in transit anyway and it looks pretty dumb toggling between softer ambient lights to harsh lights for no reason when it launches

It doesn't look too bad to me. The dropships have enough lights that there aren't really shadows anywhere, though the soft shadows on the walls disappearing does look a little odd, and the cockpit light being red is... bad, I'll probably change it.

This problem has already been, more or less, fixed in #545 (which is nearing merge) . I can't remember specifically how I did it, but it looks alright transitioning between space and ground.

Oh, well that's good.

@Ediblebomb Ediblebomb closed this Jan 6, 2025
@Ediblebomb Ediblebomb deleted the permalight-bad branch January 6, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants