-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes base area lighting from the dropships. #651
Conversation
aaaaaaaaaaaaand the images are bugged. great. perfect. |
linters whhhhhhhhhyyyyyyyy |
nevermind I'm stupid |
This reverts commit ebc0532.
this exists because they get fullbright in transit anyway and it looks pretty dumb toggling between softer ambient lights to harsh lights for no reason when it launches |
It doesn't look too bad to me. The dropships have enough lights that there aren't really shadows anywhere, though the soft shadows on the walls disappearing does look a little odd, and the cockpit light being red is... bad, I'll probably change it. |
This problem has already been, more or less, fixed in #545 (which is nearing merge) . I can't remember specifically how I did it, but it looks alright transitioning between space and ground. |
Oh, well that's good. |
About the pull request
Base area lighting in a dropship with a closed roof and lights on the map doesn't really have a reason to exist, this also adds a light to the cockpit so it's not pitch black in there.
Explain why it's good for the game
Base area lighting can look pretty silly (see below image), and the dropships already have lights mapped.
Testing Photographs and Procedure
Screenshots & Videos
![image](https://github.com/user-attachments/assets/8c511c35-e86a-4cf7-900d-ad1d982898f5) ![image](https://github.com/user-attachments/assets/ed5b2334-bab1-449e-8238-f15cead54cc0)Changelog
🆑 Ediblebomb
maptweak: Dropships no longer have base area lighting.
/:cl: