Increasing Admin Sound upload limit #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Changelog
cm13-github
added a commit
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is my first PR ever. Hopefully I did this right.
About the pull request
Since YouTube has failed us, it'd be nice to have a bit more headroom in our file uploads for playing music during the round. Harry proposed potentially tripling this value (and I wouldn't be opposed to it, personally), but this is enough for longer tracks at lower bitrates.
Explain why it's good for the game
We're currently hard-capped at 10mb for sound files. That's an awkward breakpoint when it comes to even Variable Bitrate MP3s: You get maybe 6 minutes that way. And considering our operations go for a more cinematic feel, it'd be nice to use scoring that doesn't require reconverting and compressing it from wherever you nabbed it from -- or chopping it up, god forbid.
Testing Photographs and Procedure
Logged into my local server and tried playing a 13mb mp3. It worked. Neat!
Changelog
🆑
config: define UPLOAD_LIMIT value doubled (10485760 to 20971520)