Port: Fix Werror handling in build script #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# About the pull request This PR partially ports tgstation/tgstation#83015 fixing warnings not getting treated as errors due to a regex error. We want Werror to catch common things like unused variables in CI testing. Removes an unused squad var causing warnings. # Explain why it's good for the game More robust code # Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- !! If you are modifying sprites, you **must** include one or more in-game screenshots or videos of the new sprites. !! --> https://github.com/cmss13-devs/cmss13/actions/runs/11770975974/job/32784168250?pr=7562 # Changelog No player facing changes.
github-actions
bot
added
UI
Missing Changelog
Drulikar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from cmss13-devs/cmss13#7562
About the pull request
This PR partially ports
tgstation/tgstation#83015 fixing warnings not getting treated as errors due to a regex error. We want Werror to catch common things like unused variables in CI testing.
Removes an unused squad var causing warnings.Explain why it's good for the game
More robust code
Testing Photographs and Procedure
https://github.com/cmss13-devs/cmss13/actions/runs/11770975974/job/32784168250?pr=7562
Changelog
No player facing changes.