-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG adjustments, power & ammo #535
Open
BonniePandora
wants to merge
16
commits into
cmss13-devs:master
Choose a base branch
from
BonniePandora:SG-Adaptable-ammunition-overhaul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SG adjustments, power & ammo #535
BonniePandora
wants to merge
16
commits into
cmss13-devs:master
from
BonniePandora:SG-Adaptable-ammunition-overhaul
+94
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doubleumc
previously approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code good!
XSlayer300
reviewed
Nov 16, 2024
XSlayer300
reviewed
Nov 16, 2024
XSlayer300
reviewed
Nov 16, 2024
Doubleumc
requested changes
Nov 17, 2024
Doubleumc
previously approved these changes
Nov 25, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Doubleumc
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds a new ammunition type for smartgunners to utilise; Impact Detonating. Slightly less damaging than the standard round, with less armour-penetration, but it inficts a slowdown on targets hit. Useful for crowd control, especially when up against multiple crusher-type enemies.
Power-usage per shot is increased across the board for the ammo types, with AP having a slightly higher per-shot usage and Imp-Det being a fair bit higher.
Big props to Drathek for the help throughout this.
Explain why it's good for the game
More features to engage the brains of SG players should they chose to use this stuff. Also balances the gun system a bit by making them more likely to run outa power during longer operations, encouraging them to bring their spare or engage in RP with the other for their spare.
Testing Photographs and Procedure
Tested locally repeatedly, compiles fine and functions as intended
Changelog
🆑
add: New smartgun ammo type; Impact Detonating
balance: smartguns now use more power depending on the ammo type selected.
imageadd: Icon for the ammo mode when toggled to
/:cl: