Fixes the rest of the missed Section Sergeant related things #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doubleumc
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adjusts the overwatch console to reference section sergeants/leaders instead of platoon or squad leaders.
Also fixes the squad info window when clicking on the tracker as the section sarge
May require finessing in the future to account for UPP forces still being considered a platoon rather than a section but I'm tired and spite only gets me so far with coding.
Explain why it's good for the game
Oversights from prior PR's that changed things in how the section names were handled.
Makes it so section sarges can properly move people between squads or promote someone as an acting SL for the teams
Testing Photographs and Procedure
Compiles, works as intended on local instances
Changelog
🆑
fix: Section sergeants can once more use their squad info window to swap people between squads or assign acting SL's to the two teams
ui: Overwatch console properly references sections and section leaders in the buttons now instead of squads or platoons
/:cl: