Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavy Pulse RIfle Rework #298

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

KoishiVibe
Copy link
Contributor

@KoishiVibe KoishiVibe commented Jun 16, 2024

Summary

  • Rework of the M41AE2's role.
    • E2 has irremovable integral bipod and regular folding stock. Both active will make it more powerful than the M41A in sustained fire.
    • It's serviceable on the move, but the M41A is more stable and having a grenade launcher as well as being able to shoot various different kinds of grenades hinders it.
    • While possible, it is incredibly, INCREDIBLY unserviceable to shoot onehanded. The recoil is dampened by the weight of the gun, but uh. shotgun spread dispersion.
    • The magazines are now only able to fit into general pouches, the G8, and the backpack.
  • Removes bug with hyperfast full auto.
  • Changes SFX to the M41A's.
  • Modifies E2 sprite to have no stock.
  • New integrated bipod sprite.
  • Minor tweak to APHE clip flavor text.

Changelog

🆑
add: Changed the sprite of the E2. Now it's able to fit stock attachments! It also just has the regular old folding stock by default now.
add: Adds a new sprite for the integrated bipod of the E2
add: New E2 flavortext.
qol: E2 is now Semi/4RB/FA as it should be.
balance: The M41AE2 is now more similar to the M41A. It is less capable on the move, but once its bipod is down it can take full advantage of the 300rnd clipsize with stable full auto firing.
balance: The M41AE2 can now be onehanded! Hit accuracy is near zero, don't do this unless things are increeeeeedibly desperate.
balance: Magazine boxes now hold 4. As a result their detonation is basically catastrophic.
fix: Fixes the FA bug with the E2
code: Adds exception for the E2 to the RPM booster of the bipod
code: Adds some attachment modifiers for fa_max_scatter and fa_scatter_peak. Linear.
maptweak: Replaces the E2 holotarget spawn on LV522 Forecon with a regular ammo spawn.
/:cl:

Copy link
Contributor Author

@KoishiVibe KoishiVibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing is complete. Standing by for review. I kind of want to nerf the moving scatter a little though...

@KoishiVibe KoishiVibe marked this pull request as ready for review June 22, 2024 06:17
@KoishiVibe
Copy link
Contributor Author

todo:

  • art pass to make the stock and bipod seem more integral
  • balancing pass, I suspect the basic nonextended mode needs to be scatter nerfed to make it less accurate?

Copy link
Contributor Author

@KoishiVibe KoishiVibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature complete, more or less. Ready to rock!

@AndroBetel
Copy link
Contributor

will be testmerged on red

@KoishiVibe
Copy link
Contributor Author

Nerf consists of a reduction in general scatter and accuracy, especially onehanded. Hopefully it should remain great in bipod with stock out and acceptable with stock open on the go.

I'll code a custom section for it tomorrow and also have the bipod reduce scatter while active.

@KoishiVibe
Copy link
Contributor Author

hokay. ammo path fixed and damage should be corrected.

@github-actions github-actions bot added Feature Quality of Life Balance fix Code Improvement and removed Missing Changelog Maintainers always document their changes. labels Nov 19, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants