Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ScoutingNano integration with autoNano #46516

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patinkaew
Copy link
Contributor

(This is currently a draft PR to help facilitate initial code review. If this gets green light, we will remove this line and change to actual PR)

PR description:

This PR improves ScoutingNano integration with autoNano. This mainly concerns using ScoutingNano flavour in combination with other nano flavours. The primary use case is in scouting vs offline object comparison studies using ScoutingPFMonitor datasets. Currently, ScoutingNano configuration replaces nanoSequence which is also used in standard nano, making combining ScoutingNano with standard NanoAOD unclear and difficult. While there exist recipes to compose scouting+standard, they are not intuitive and do not use the autoNano functionalities. Hence, this PR implements changes to allow combining scouting+standard with autoNano. This is achieved by creating new scoutingNanoSequence in the configuration file and not altering standard nanoSequence. For combining scouting+standard, both scoutingNanoSequence and nanoSequence will be scheduled on different paths to run. Additionally, in principle, ScoutingNano will be able to combine with other nano flavours in autoNano as well.

The changes also aims to better integrate with T0 processing workflow to prepare for scouting+standard NanoAOD production for ScoutingPFMonitor dataset in the future.

In addition, we use this opportunity to also

  • Apply general code clean up.
  • Implement customise functions for use with cmsDriver.py --customise:
    • add back scouting tracks and PF candidates after they were dropped in the previous PR for private production
  • Reclustered jets use already-implemented energy fractions as opposed to recalculation as expressed in SimplePFJetFlatTable producer.

An accompanying documentation for this change is also available [1]. Examples using autoNano are provided and checked.

PR validation:

Pass all tests from scram b runtests use-ibeos

Creating test log file logs/el9_amd64_gcc12/testing.log
>> Created tmp/el9_amd64_gcc12/das_client/dasgoclient
Pass   51s ... Configuration/Applications/TestConfigurationApplicationsConfigBuilder
>> Creating project symlinks
Pass   13s ... PhysicsTools/NanoAOD/testPhysicsToolsNanoAODTP
>> Test sequence completed for CMSSW CMSSW_14_2_0_pre1

Pass all tests from runTheMatrix.py -l limited -i all --ibeos

44 43 41 36 19 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport and there is currently no plan for a backport.

[1] https://codimd.web.cern.ch/s/_sVpKamo5

@cmsbuild
Copy link
Contributor

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @patinkaew for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants