Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticl: Optimize calculation of Trackster time #46133

Merged
merged 1 commit into from
Oct 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 31 additions & 38 deletions RecoHGCal/TICL/plugins/TrackstersPCA.cc
Original file line number Diff line number Diff line change
Expand Up @@ -243,57 +243,54 @@ std::pair<float, float> ticl::computeLocalTracksterTime(const Trackster &trackst
size_t N) {
float tracksterTime = 0.;
float tracksterTimeErr = 0.;
std::set<uint32_t> usedLC;

auto project_lc_to_pca = [](const std::vector<double> &point, const std::vector<double> &segment_end) {
double dot_product = 0.0;
double segment_dot = 0.0;
auto project_lc_to_pca = [](const std::array<float, 3> &point, const std::array<float, 3> &segment_end) {
float dot_product = 0.0;
float segment_dot = 0.0;

for (int i = 0; i < 3; ++i) {
dot_product += point[i] * segment_end[i];
segment_dot += segment_end[i] * segment_end[i];
}

double projection = 0.0;
float projection = 0.0;
if (segment_dot != 0.0) {
projection = dot_product / segment_dot;
}

std::vector<double> closest_point(3);
std::array<float, 3> closest_point;
for (int i = 0; i < 3; ++i) {
closest_point[i] = projection * segment_end[i];
}

double distance = 0.0;
float distanceSquared = 0.f;
for (int i = 0; i < 3; ++i) {
distance += std::pow(point[i] - closest_point[i], 2);
distanceSquared += std::pow(point[i] - closest_point[i], 2);
}

return std::sqrt(distance);
return distanceSquared;
};

constexpr double c = 29.9792458; // cm/ns
constexpr float c = 29.9792458; // cm/ns
for (size_t i = 0; i < N; ++i) {
// Add timing from layerClusters not already used
if ((usedLC.insert(trackster.vertices(i))).second) {
float timeE = layerClustersTime.get(trackster.vertices(i)).second;
if (timeE > 0.f) {
float time = layerClustersTime.get(trackster.vertices(i)).first;
timeE = 1.f / pow(timeE, 2);
float x = layerClusters[trackster.vertices(i)].x();
float y = layerClusters[trackster.vertices(i)].y();
float z = layerClusters[trackster.vertices(i)].z();

if (project_lc_to_pca({x, y, z}, {barycenter[0], barycenter[1], barycenter[2]}) < 3) { // set MR to 3
float deltaT = 1.f / c *
std::sqrt(((barycenter[2] / z - 1.f) * x) * ((barycenter[2] / z - 1.f) * x) +
((barycenter[2] / z - 1.f) * y) * ((barycenter[2] / z - 1.f) * y) +
(barycenter[2] - z) * (barycenter[2] - z));
time = std::abs(barycenter[2]) < std::abs(z) ? time - deltaT : time + deltaT;

tracksterTime += time * timeE;
tracksterTimeErr += timeE;
}
float timeE = layerClustersTime.get(trackster.vertices(i)).second;
if (timeE > 0.f) {
float time = layerClustersTime.get(trackster.vertices(i)).first;
timeE = 1.f / pow(timeE, 2);
float x = layerClusters[trackster.vertices(i)].x();
float y = layerClusters[trackster.vertices(i)].y();
float z = layerClusters[trackster.vertices(i)].z();

if (project_lc_to_pca({{x, y, z}}, {{barycenter[0], barycenter[1], barycenter[2]}}) < 9.f) { // set MR to 3
float invz = 1.f / z;
float deltaT = 1.f / c *
std::sqrt(((barycenter[2] * invz - 1.f) * x) * ((barycenter[2] * invz - 1.f) * x) +
((barycenter[2] * invz - 1.f) * y) * ((barycenter[2] * invz - 1.f) * y) +
(barycenter[2] - z) * (barycenter[2] - z));
time = std::abs(barycenter[2]) < std::abs(z) ? time - deltaT : time + deltaT;

tracksterTime += time * timeE;
tracksterTimeErr += timeE;
}
}
}
Expand All @@ -308,16 +305,12 @@ std::pair<float, float> ticl::computeTracksterTime(const Trackster &trackster,
size_t N) {
std::vector<float> times;
std::vector<float> timeErrors;
std::set<uint32_t> usedLC;

for (size_t i = 0; i < N; ++i) {
// Add timing from layerClusters not already used
if ((usedLC.insert(trackster.vertices(i))).second) {
float timeE = layerClustersTime.get(trackster.vertices(i)).second;
if (timeE > 0.f) {
times.push_back(layerClustersTime.get(trackster.vertices(i)).first);
timeErrors.push_back(1.f / pow(timeE, 2));
}
float timeE = layerClustersTime.get(trackster.vertices(i)).second;
if (timeE > 0.f) {
times.push_back(layerClustersTime.get(trackster.vertices(i)).first);
timeErrors.push_back(1.f / pow(timeE, 2));
}
}

Expand Down