Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pair<LocalVector,LocalVector> and pair<LocalPoint,LocalPoint> dictionaries to DataFormats/GeometryVector #45564

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

makortel
Copy link
Contributor

PR description:

DataFormats/GeometryVector is the right place as it defines the Vector3DBase and Point3DBase class templates. Found with #45423 (comment).

Resolves cms-sw/framework-team#967

PR validation:

Code compiles, and the to-be-added edmDumpClassVersion succeeds to process the classes_def.xml files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • AnalysisDataFormats/TrackInfo (analysis)
  • DataFormats/GeometryVector (simulation)

@civanch, @cmsbuild, @mdhildreth, @tvami can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

type -changes-dataformats

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6af1cf/40624/summary.html
COMMIT: 304f488
CMSSW: CMSSW_14_1_X_2024-07-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45564/40624/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@tvami
Copy link
Contributor

tvami commented Jul 26, 2024

+1

@makortel
Copy link
Contributor Author

The comparison differences are related to #39803

@civanch
Copy link
Contributor

civanch commented Jul 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3311f3a into cms-sw:master Jul 29, 2024
11 checks passed
@makortel makortel deleted the fixDictionariesLVLP branch July 29, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment