-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use max instead if infinity which hasundefined behavior #45488
Conversation
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45488/40956 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test for CMSSW_14_1_CLANG_X |
a6977b4
to
3d04e1f
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45488/40959 |
Pull request #45488 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again. |
please test for CMSSW_14_1_CLANG_X |
please test Run production arch tests too |
+1 Size: This PR adds an extra 28KB to repository
Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c73922/40465/summary.html Comparison SummarySummary:
|
fixes #45181 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Fixes #45181
As proposed in #45181 (comment) , this PR replaces
std::numeric_limits<float>::infinity()
withstd::numeric_limits<float>::max()
. This should fix the compilation warnings in CLANG IBs.[a]