Use max instead if infinity which hasundefined behavior #45488

smuzaffar · 2024-07-18T07:51:15Z

As proposed in #45181 (comment) , this PR replaces std::numeric_limits<float>::infinity() with std::numeric_limits<float>::max() . This should fix the compilation warnings in CLANG IBs.

[a]

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_CLANG_X_2024-07-17-1700/RecoEgamma/EgammaPhotonAlgos

  src/DataFormats/EgammaReco/interface/ElectronSeed.h:115:46: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   115 |     void setNegAttributes(const float dRZ2 = std::numeric_limits<float>::infinity(),
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:116:47: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   116 |                           const float dPhi2 = std::numeric_limits<float>::infinity(),
      |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:117:46: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   117 |                           const float dRZ1 = std::numeric_limits<float>::infinity(),
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:118:47: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   118 |                           const float dPhi1 = std::numeric_limits<float>::infinity());
      |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:119:46: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   119 |     void setPosAttributes(const float dRZ2 = std::numeric_limits<float>::infinity(),
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:120:47: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   120 |                           const float dPhi2 = std::numeric_limits<float>::infinity(),
      |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:121:46: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   121 |                           const float dRZ1 = std::numeric_limits<float>::infinity(),
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:122:47: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   122 |                           const float dPhi1 = std::numeric_limits<float>::infinity());
      |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:143:63: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   143 |       return hitNr < hitInfo_.size() ? hitInfo_[hitNr].*val : std::numeric_limits<T>::infinity();
      |                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/DataFormats/EgammaReco/interface/ElectronSeed.h:102:48: note: in instantiation of function template specialization 'reco::ElectronSeed::getVal<float>' requested here
  102 |     float dPhiNeg(size_t hitNr) const { return getVal(hitNr, &PMVars::dPhiNeg); }
      |                                                ^
  src/DataFormats/EgammaReco/interface/ElectronSeed.h:143:63: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
   143 |       return hitNr < hitInfo_.size() ? hitInfo_[hitNr].*val : std::numeric_limits<T>::infinity();

smuzaffar · 2024-07-18T07:51:27Z

please test

cmsbuild · 2024-07-18T07:51:43Z

cms-bot internal usage

cmsbuild · 2024-07-18T07:56:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45488/40956

cmsbuild · 2024-07-18T07:56:53Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

DataFormats/EgammaReco (reconstruction)
DataFormats/Math (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @Sam-Harper, @a-kapoor, @afiqaize, @fabiocos, @felicepantaleo, @jainshilpi, @lgray, @makortel, @missirol, @mmusich, @rovere, @sameasy, @sobhatta, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-07-18T08:39:08Z

please test for CMSSW_14_1_CLANG_X

cmsbuild · 2024-07-18T10:31:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45488/40959

cmsbuild · 2024-07-18T10:31:22Z

Pull request #45488 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

jfernan2 · 2024-07-18T10:41:02Z

please test for CMSSW_14_1_CLANG_X
It got stuck somehow

smuzaffar · 2024-07-18T10:52:07Z

please test

Run production arch tests too

cmsbuild · 2024-07-18T14:56:53Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c73922/40466/summary.html
COMMIT: 3d04e1f
CMSSW: CMSSW_14_1_X_2024-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45488/40466/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 13273 lines to the logs
Reco comparison results: 549 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345208
DQMHistoTests: Total failures: 3562
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3341626
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 1 / 46 workflows

cmsbuild · 2024-07-18T16:47:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c73922/40465/summary.html
COMMIT: 3d04e1f
CMSSW: CMSSW_14_1_CLANG_X_2024-07-17-1700/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45488/40465/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 13795 lines to the logs
Reco comparison results: 36751 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345208
DQMHistoTests: Total failures: 35252
DQMHistoTests: Total nulls: 120
DQMHistoTests: Total successes: 3309816
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.05 KiB( 47 files compared)
DQMHistoSizes: changed ( 140.043 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 140.063 ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 141.042 ): 0.023 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 141.044 ): 0.043 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 7 / 46 workflows

jfernan2 · 2024-07-18T16:48:37Z

fixes #45181

jfernan2 · 2024-07-18T16:48:45Z

+1

cmsbuild · 2024-07-18T16:49:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-07-18T18:10:12Z

+1

mmusich · 2024-10-21T14:11:20Z

Looks like this

was ignored in the review.

cmsbuild added this to the CMSSW_14_1_X milestone Jul 18, 2024

cmsbuild added reconstruction-pending pending-signatures orp-pending tests-started code-checks-pending labels Jul 18, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 18, 2024

use max instead if infinity which hasundefined behavior

3d04e1f

smuzaffar force-pushed the 141x-max-to-infinity branch from a6977b4 to 3d04e1f Compare July 18, 2024 10:28

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Jul 18, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 18, 2024

cmsbuild added tests-started and removed tests-pending labels Jul 18, 2024

cmsbuild added tests-approved and removed tests-started labels Jul 18, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jul 18, 2024

cmsbuild added orp-approved and removed orp-pending labels Jul 18, 2024

cmsbuild merged commit a18756f into cms-sw:master Jul 18, 2024
17 checks passed

mmusich mentioned this pull request Oct 10, 2024

[HLT] [Clang]Cleanup clang-analyzer warnings #46319

Open

rovere mentioned this pull request Oct 21, 2024

Noisy ElectronSeedProducer in 2024 and Phase-2 worfklows #45658

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use max instead if infinity which hasundefined behavior #45488

Use max instead if infinity which hasundefined behavior #45488

smuzaffar commented Jul 18, 2024

smuzaffar commented Jul 18, 2024

cmsbuild commented Jul 18, 2024 •

edited

Loading

cmsbuild commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

smuzaffar commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

jfernan2 commented Jul 18, 2024

smuzaffar commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

jfernan2 commented Jul 18, 2024

jfernan2 commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

rappoccio commented Jul 18, 2024

mmusich commented Oct 21, 2024

Use max instead if infinity which hasundefined behavior #45488

Use max instead if infinity which hasundefined behavior #45488

Conversation

smuzaffar commented Jul 18, 2024

smuzaffar commented Jul 18, 2024

cmsbuild commented Jul 18, 2024 • edited Loading

cmsbuild commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

smuzaffar commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

jfernan2 commented Jul 18, 2024

smuzaffar commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

Comparison Summary

cmsbuild commented Jul 18, 2024

Comparison Summary

jfernan2 commented Jul 18, 2024

jfernan2 commented Jul 18, 2024

cmsbuild commented Jul 18, 2024

rappoccio commented Jul 18, 2024

mmusich commented Oct 21, 2024

cmsbuild commented Jul 18, 2024 •

edited

Loading