update to remove per bx roc data

[duff-ae]

PR description:

The modules affected:
Calibration/LumiAlCaRecoProducers
DataFormats/Luminosity

Minor change to the structure of per roc data. Effectively removes per bx granularity (hence reducing the array size by 3563), to resolve the memory usage issue raised in #45306

Original PR #44996

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45348/40762

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45348/40762/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45348/40762/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45348/40763

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @duff-ae for master.

It involves the following packages:

• DataFormats/Luminosity (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-272e20/40158/summary.html
COMMIT: 7c3e443
CMSSW: CMSSW_14_1_X_2024-06-30-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45348/40158/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 1993 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 467
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344601
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[mandrenguyen]

+1
Is this going to be backported to 14_0_X?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[mmusich]

@duff-ae is there a backport for this PR?

[duff-ae]

@mmusich I don't think so, we had a backport (#45054) prepared by @perrotta for the original PR

[mmusich]

don't think so

then I think we need one. We're running in production in CMSSW_14_0_X so the issue #45306 won't be solved by this.
(allow me to point out that CMSSW_14_0_10 recently built will suffer by the same issue @srimanob FYI).

[srimanob]

OK, Thanks. We missed this one T_T
So 14_0_10 is almost useless with this missing. I am sorry @antoniovilela

[perrotta]

Here's the backport (to speed up the fix): #45369

[mandrenguyen]

type lumi