Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for low-level alpaka based utilities [14.0.x] #44650

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 7, 2024

PR description:

Fix various low-level alpaka based utilities that were inadvertently mixing host and device code.

Required to build with alpaka in GPU-only mode.

PR validation:

Unit tests pass.

No impact on the HLT performance, as expected.
CMSSW_14_0_4:

Running 4 times over all events with 8 jobs, each with 32 threads, 24 streams and 1 GPUs
   514.3 ±   0.4 ev/s (11800 events, 99.8% overlap)
   533.3 ±   0.5 ev/s (11800 events, 99.7% overlap)
   523.0 ±   0.6 ev/s (11800 events, 100.0% overlap)
   514.8 ±   0.6 ev/s (11800 events, 99.3% overlap)
 --------------------
   521.3 ±   8.9 ev/s

CMSSW_14_0_4 with #44650:

Running 4 times over all events with 8 jobs, each with 32 threads, 24 streams and 1 GPUs
   520.0 ±   0.5 ev/s (11800 events, 99.8% overlap)
   505.8 ±   0.4 ev/s (11800 events, 99.8% overlap)
   559.7 ±   0.5 ev/s (11800 events, 99.8% overlap)
   514.0 ±   0.5 ev/s (11800 events, 99.9% overlap)
 --------------------
   524.9 ±  23.9 ev/s

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44640 to CMSSW 14.0.x for data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 7, 2024

type bugfix

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 7, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 7, 2024

backport #44640

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@fwyzard, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@missirol, @makortel, @rovere this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 7, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 7, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 7, 2024

please test

@fwyzard fwyzard changed the title Fixes for low-level alpaka based utilities (14.0.x) Fixes for low-level alpaka based utilities [14.0.x] Apr 7, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bd6ae/38659/summary.html
COMMIT: af05c33
CMSSW: CMSSW_14_0_X_2024-04-07-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44650/38659/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 509
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39231
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmsdist#9125, please check if they should be merged together

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 8, 2024

REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmsdist#9125, please check if they should be merged together

No, this PR should be merged before cms-sw/cmsdist#9125, but it can also be merged without it.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 310a744 into cms-sw:CMSSW_14_0_X Apr 9, 2024
13 checks passed
@fwyzard fwyzard deleted the alpaka_code_fixes_140x branch April 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants