Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scouting NANO in autonano #44399

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Scouting NANO in autonano #44399

merged 3 commits into from
Mar 25, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Mar 14, 2024

PR description:

The original implementation used a customise : this PR makes the scouting nano use the NANO:@Scout syntax.
The two files solution originally used is also removed (#43847)

PR validation:

nano matrix ran

tagging @alintulu

@vlimant
Copy link
Contributor Author

vlimant commented Mar 14, 2024

enable nano

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44399/39471

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vlimant for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • PhysicsTools/NanoAOD (xpog)

@sunilUIET, @rappoccio, @srimanob, @subirsarkar, @davidlange6, @miquork, @antoniovilela, @hqucms, @cmsbuild, @vlimant, @AdrianoDee, @fabiocos can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc, @Martin-Grunewald, @missirol, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Mar 14, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce9734/38130/summary.html
COMMIT: f12d0a4
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44399/38130/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce9734/38130/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce9734/38130/git-merge-result

Build

I found compilation error when building:

>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling  src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory
   19 | #include "onnxruntime/onnxruntime_cxx_api.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package CalibTracker/SiStripCommon
>> Entering Package CalibTracker/SiStripLorentzAngle
>> Entering Package PhysicsTools/NanoAOD
>> Entering Package PhysicsTools/ONNXRuntime
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-03-13-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Alignment/OfflineValidation
>> Compiling  src/Alignment/OfflineValidation/bin/Options.cc
>> Compiling  src/Alignment/OfflineValidation/bin/DMRmerge.cc


@vlimant
Copy link
Contributor Author

vlimant commented Mar 14, 2024

this error cannot be related to the changes in the PR

@vlimant
Copy link
Contributor Author

vlimant commented Mar 15, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce9734/38146/summary.html
COMMIT: f12d0a4
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44399/38146/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially removed 992 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1627 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 358
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297005
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially added 18933 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1584 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 352
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16050
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 44 log files, 24 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.51-size.json
  • Nano ERROR: Missing ref/2500.51-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 5.20 | 5.25 | -1.1% | 2.148 | 2.110 |
    | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 4.62 | 4.70 | -1.7% | 2.567 | 2.126 |
    | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.80 | 4.92 | -2.3% | 2.555 | 2.145 |
    | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.19 | 9.55 | -3.8% | 2.246 | 2.122 |
    | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.06 | 5.16 | -2.0% | 2.406 | 1.992 |
    | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.19 | 7.41 | -2.9% | 2.278 | 2.017 |
    | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.24 | 5.26 | -0.4% | 2.061 | 2.041 |
    | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 6.01 | 6.07 | -0.9% | 1.974 | 1.842 |
    | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 4.28 | 4.31 | -0.5% | 2.262 | 1.843 |
    | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 3.69 | 3.70 | -0.2% | 2.247 | 1.944 |
    | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.17 | 12.55 | -3.1% | 1.961 | 1.961 |
    | 2500.301 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 9.88 | 10.02 | -1.4% | 1.952 | 1.949 |
    | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 18.99 | 19.85 | -4.3% | 2.341 | 2.355 |
    | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 13.16 | 13.78 | -4.5% | 2.323 | 2.318 |
    | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.32 | 1.45 | -8.9% | 1.710 | 1.701 |
    | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.56 | 6.93 | -5.4% | 1.057 | 1.055 |
    | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 13.39 | 13.95 | -4.0% | 2.050 | 2.050 |
    | 2500.315 | 1.758 | 1.758 | 0.000 ( +0.0% ) | 12.88 | 14.02 | -8.2% | 2.316 | 1.946 |
    | 2500.316 | 1.787 | 1.787 | 0.000 ( +0.0% ) | 13.27 | 13.26 | +0.1% | 2.186 | 1.878 |
    | 2500.4 | 2.220 | 2.058 | 0.162 ( +7.9% ) | 11.81 | 12.43 | -5.0% | 1.812 | 1.568 |
    | 2500.401 | 1.755 | 1.824 | -0.069 ( -3.8% ) | 10.19 | 10.61 | -4.0% | 1.756 | 1.642 |
    | 2500.402 | 2.764 | 2.631 | 0.133 ( +5.1% ) | 9.24 | 10.21 | -9.5% | 1.914 | 1.819 |
    | 2500.403 | 2.771 | 2.620 | 0.151 ( +5.7% ) | 9.24 | 10.26 | -10.0% | 1.776 | 1.915 |
    | 2500.5 | 4.936 | 19.575 | -14.639 ( -74.8% ) | 16.01 | 1.23 | +1204.4% | 1.530 | 1.127 |

@AdrianoDee
Copy link
Contributor

+pdmv

@vlimant
Copy link
Contributor Author

vlimant commented Mar 22, 2024

who's signing for @cms-sw/operations-l2 ? can this be bypassed ? or can I be given the signature of that category please

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44399/39650

@cmsbuild
Copy link
Contributor

Pull request #44399 was updated. @antoniovilela, @rappoccio, @cmsbuild, @fabiocos, @davidlange6 can you please check and sign again.

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce9734/38379/summary.html
COMMIT: 1916ae3
CMSSW: CMSSW_14_1_X_2024-03-25-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44399/38379/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially removed 1173 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1649 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297537
  • DQMHistoTests: Total failures: 1713
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3295804
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially added 18930 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1584 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 352
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16050
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 46 log files, 26 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.51-size.json
  • Nano ERROR: Missing ref/2500.51-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 4.39 | 4.56 | -3.7% | 2.180 | 2.145 |
    | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 3.96 | 4.08 | -2.8% | 2.659 | 2.547 |
    | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.13 | 4.25 | -2.8% | 2.602 | 2.516 |
    | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 7.96 | 8.27 | -3.8% | 2.355 | 2.261 |
    | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 4.42 | 4.54 | -2.7% | 2.513 | 2.408 |
    | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 6.21 | 6.47 | -3.9% | 2.404 | 2.303 |
    | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 4.63 | 4.62 | +0.3% | 2.064 | 1.968 |
    | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 5.14 | 5.26 | -2.1% | 1.974 | 1.870 |
    | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 3.52 | 3.54 | -0.6% | 2.261 | 2.133 |
    | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 2.77 | 3.12 | -11.1% | 2.342 | 2.206 |
    | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 9.44 | 10.11 | -6.6% | 1.960 | 1.964 |
    | 2500.301 | 2.630 | 2.630 | 0.000 ( +0.0% ) | 4.82 | 8.61 | -44.0% | 1.942 | 1.945 |
    | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 12.85 | 13.08 | -1.8% | 2.325 | 2.261 |
    | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 7.72 | 9.86 | -21.7% | 2.424 | 2.322 |
    | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 0.94 | 1.34 | -29.5% | 1.702 | 1.705 |
    | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 2.29 | 5.94 | -61.4% | 1.053 | 1.048 |
    | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 8.48 | 10.16 | -16.5% | 2.210 | 2.060 |
    | 2500.315 | 1.756 | 1.756 | 0.000 ( +0.0% ) | 6.96 | 10.21 | -31.8% | 2.322 | 2.319 |
    | 2500.316 | 3.091 | 3.091 | 0.000 ( +0.0% ) | 1.73 | 1.81 | -4.3% | 2.114 | 1.962 |
    | 2500.317 | 1.787 | 1.787 | 0.000 ( +0.0% ) | 7.53 | 9.71 | -22.4% | 2.330 | 2.240 |
    | 2500.4 | 2.220 | 2.058 | 0.162 ( +7.9% ) | 9.61 | 10.20 | -5.8% | 1.893 | 1.905 |
    | 2500.401 | 1.755 | 1.824 | -0.069 ( -3.8% ) | 7.18 | 8.84 | -18.9% | 1.747 | 1.684 |
    | 2500.402 | 2.763 | 2.630 | 0.133 ( +5.1% ) | 6.76 | 8.47 | -20.2% | 1.898 | 1.948 |
    | 2500.403 | 5.065 | 5.188 | -0.123 ( -2.4% ) | 1.31 | 1.29 | +2.1% | 1.966 | 1.819 |
    | 2500.404 | 2.771 | 2.620 | 0.151 ( +5.7% ) | 5.87 | 7.99 | -26.5% | 1.837 | 1.413 |
    | 2500.5 | 4.936 | 19.575 | -14.639 ( -74.8% ) | 14.79 | 0.84 | +1656.0% | 1.568 | 1.361 |

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 589a0a1 into cms-sw:master Mar 25, 2024
13 checks passed
@vlimant vlimant deleted the scouting_autonano branch April 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants