Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue TAxis::SetRangeUser() warnings as INFO messages instead of an exception #44060

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

makortel
Copy link
Contributor

PR description:

To work around the failures reported in tests of ROOT master update in cms-sw/cmsdist#9025 (comment) . The condition where ROOT issues these messages does not seem to warrant job termination, even if their cause would be useful to be fixed in our code.

PR validation:

Code compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44060/39004

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • FWCore/Services (core)

@makortel, @Dr15Jones, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@wddgit, @missirol, @fwyzard this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eae1da/37629/summary.html
COMMIT: 1d6ae2f
CMSSW: CMSSW_14_1_X_2024-02-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44060/37629/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 73614ba into cms-sw:master Feb 26, 2024
11 checks passed
@makortel makortel deleted the initRootHandlersTAxisRangeUser branch February 26, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants