-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable seedingDeepCore displacedRegionalTracking in phase-1 eras #43472
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43472/38032
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@fabiocos, @davidlange6, @antoniovilela, @cmsbuild, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
type tracking |
-1 Failed Tests: RelVals RelVals-INPUT RelValsThe relvals timed out after 4 hours.
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ... |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43472/38043
|
is there anything else similar that I missed in HI context ? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43472/38048
|
@cmsbuild please test |
Pull request #43472 was updated. @antoniovilela, @mandrenguyen, @rappoccio, @fabiocos, @jfernan2, @davidlange6 can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470139/36279/summary.html Comparison SummarySummary:
|
+reconstruction |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
@slava77 thanks for the suggestion. cms-sw/cms-bot#2127 should take care of such failed relvals |
…ignTRK002/dnnFix followup fixes after enabling seedingDeepCore displacedRegionalTracking in #43472
Following a presentation in the RECO meeting
https://indico.cern.ch/event/1352807/#13-tracking-devs-tagetting-202
it was proposed by RECO to validate the tracking updates directly in the production setup
This PR enables seedingDeepCore displacedRegionalTracking in phase-1 eras by default
and this way can naturally be covered in 14_0_0_pre2 relvals.
In case a revert is needed, it will be simple to go back.
The updates in tracking are somewhat restricted to either high pt hadronic jets or to very displaced tracks. This should have little interference of other possible more prompt-related updates.
@cms-sw/reconstruction-l2
@cms-sw/tracking-pog-l2