enable seedingDeepCore displacedRegionalTracking in phase-1 eras #43472

slava77 · 2023-12-01T15:41:45Z

Following a presentation in the RECO meeting
https://indico.cern.ch/event/1352807/#13-tracking-devs-tagetting-202

it was proposed by RECO to validate the tracking updates directly in the production setup

This PR enables seedingDeepCore displacedRegionalTracking in phase-1 eras by default
and this way can naturally be covered in 14_0_0_pre2 relvals.
In case a revert is needed, it will be simple to go back.

The updates in tracking are somewhat restricted to either high pt hadronic jets or to very displaced tracks. This should have little interference of other possible more prompt-related updates.

@cms-sw/reconstruction-l2
@cms-sw/tracking-pog-l2

…lows

cmsbuild · 2023-12-01T15:47:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43472/38032

This PR adds an extra 16KB to repository

cmsbuild · 2023-12-01T15:47:44Z

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/Eras (operations)

@fabiocos, @davidlange6, @antoniovilela, @cmsbuild, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @AnnikaStein, @makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

slava77 · 2023-12-01T16:01:40Z

@cmsbuild please test

slava77 · 2023-12-01T16:06:28Z

type tracking

cmsbuild · 2023-12-01T20:30:02Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470139/36261/summary.html
COMMIT: e11d70d
CMSSW: CMSSW_14_0_X_2023-12-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43472/36261/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

2018.1

----- Begin Fatal Exception 01-Dec-2023 17:27:39 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step'
   [2] Prefetching for module MultiTrackValidator/'trackValidatorJetCore'
   [3] Calling method for module TrackCollectionMerger/'jetCoreRegionalStepTracks'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Track>
Looking for module label: jetCoreRegionalStepBarrelTracks
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

13234.0

----- Begin Fatal Exception 01-Dec-2023 17:40:16 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step'
   [2] Prefetching for module MultiTrackValidator/'trackValidatorJetCore'
   [3] Calling method for module TrackCollectionMerger/'jetCoreRegionalStepTracks'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Track>
Looking for module label: jetCoreRegionalStepBarrelTracks
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

14034.0

----- Begin Fatal Exception 01-Dec-2023 17:41:47 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step'
   [2] Prefetching for module MultiTrackValidator/'trackValidatorJetCore'
   [3] Calling method for module TrackCollectionMerger/'jetCoreRegionalStepTracks'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Track>
Looking for module label: jetCoreRegionalStepBarrelTracks
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

14234.0

RelVals-INPUT

13234.013234.0_TTbar_14TeV+2021FS/step2_TTbar_14TeV+2021FS.log
13434.013434.0_TTbar_14TeV+2021FSPU/step2_TTbar_14TeV+2021FSPU.log
14034.014034.0_TTbar_14TeV+2023FS/step2_TTbar_14TeV+2023FS.log

Expand to see more relval errors ...

14234.0

cmsbuild · 2023-12-01T23:20:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43472/38043

This PR adds an extra 20KB to repository

slava77 · 2023-12-02T15:16:33Z

@mandrenguyen
I disabled displacedRegional for pp_on_AA and pp_on_XeXe
I suppose, pA is going to be OK.

is there anything else similar that I missed in HI context ?

cmsbuild · 2023-12-02T15:21:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43472/38048

This PR adds an extra 24KB to repository

slava77 · 2023-12-02T15:22:12Z

@cmsbuild please test

cmsbuild · 2023-12-02T15:22:21Z

Pull request #43472 was updated. @antoniovilela, @mandrenguyen, @rappoccio, @fabiocos, @jfernan2, @davidlange6 can you please check and sign again.

cmsbuild · 2023-12-02T18:56:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470139/36279/summary.html
COMMIT: 5b1e007
CMSSW: CMSSW_14_0_X_2023-12-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43472/36279/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 98 lines to the logs
Reco comparison results: 9682 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3369386
DQMHistoTests: Total failures: 5427
DQMHistoTests: Total nulls: 274
DQMHistoTests: Total successes: 3363663
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 160466.56600000005 KiB( 49 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 8764.192 KiB Tracking/JetCore
DQMHistoSizes: changed ( 10024.0,... ): 756.855 KiB Tracking/Track
DQMHistoSizes: changed ( 10024.0,... ): 201.715 KiB Tracking/TrackTPPtLess09
DQMHistoSizes: changed ( 10024.0,... ): 180.709 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 10024.0,... ): 166.715 KiB Tracking/TrackBuilding
DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 13234.0,... ): 8667.796 KiB Tracking/JetCore
DQMHistoSizes: changed ( 13234.0,... ): 742.191 KiB Tracking/Track
DQMHistoSizes: changed ( 141.044 ): 0.051 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 312.0 ): ...
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 16 / 48 workflows

mandrenguyen · 2023-12-04T06:41:41Z

+reconstruction
Not much change to MC workflows, but looks like there's just not enough stats.
Real data shows changes to the track distributions, e.g.:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2023-12-02-1100+470139/60119/validateJR/141.044_RunJetMET2023D/all_reRECO_step3/c_log10recoTracks_generalTracks__reRECO_obj_pt.png

antoniovilela · 2023-12-04T13:56:06Z

+1

cmsbuild · 2023-12-04T13:56:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

smuzaffar · 2023-12-06T12:58:53Z

in the last round of tests it looks like 140.56_RunHI2018/step2 crashed.

Thanks. Still, how did you find it?

since there is a clear A fatal system signal has occurred: external termination request some basic grep could be done for the PR test summary. @iarspider @smuzaffar can it be added?

@slava77 thanks for the suggestion. cms-sw/cms-bot#2127 should take care of such failed relvals

…ignTRK002/dnnFix followup fixes after enabling seedingDeepCore displacedRegionalTracking in #43472

slava77 added 2 commits December 1, 2023 07:32

enable seedingDeepCore and displacedRegionalTracking in phase-1 workf…

006bc0f

…lows

exclude seedingDeepCore and displacedRegionalTracking from phase-2

e11d70d

cmsbuild added this to the CMSSW_14_0_X milestone Dec 1, 2023

cmsbuild added operations-pending pending-signatures tests-pending orp-pending code-checks-pending labels Dec 1, 2023

slava77 mentioned this pull request Dec 1, 2023

temporarily add deepCore and displacedRegional workflows to runTheMatrix #43458

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 1, 2023

cmsbuild added tests-started and removed tests-pending labels Dec 1, 2023

cmsbuild added the tracking label Dec 1, 2023

cmsbuild added tests-rejected and removed tests-started labels Dec 1, 2023

add short-circuit parts for jetCore with fastSim and seedingDeepCore

a0d9620

cmsbuild added reconstruction-pending tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Dec 1, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 1, 2023

cmsbuild added tests-pending code-checks-pending and removed code-checks-approved labels Dec 2, 2023

cmsbuild added tests-started code-checks-approved and removed tests-pending code-checks-pending labels Dec 2, 2023

cmsbuild added tests-approved and removed tests-started labels Dec 2, 2023

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 4, 2023

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Dec 4, 2023

cmsbuild merged commit a4e31c0 into cms-sw:master Dec 4, 2023
11 checks passed

cmsbuild mentioned this pull request Dec 5, 2023

Phase2 Trigger Primitive generation for Ecal Barrel #42633

Merged

mmusich mentioned this pull request Dec 5, 2023

ProductNotFound error in module MultiTrackValidator/'trackValidatorJetCoreSeedingTrackingOnly' #43495

Closed

cmsbuild added a commit that referenced this pull request Jan 16, 2024

Merge pull request #43565 from slava77/CMSSW_14_0_X_2023-12-13-1100/s…

1faff5c

…ignTRK002/dnnFix followup fixes after enabling seedingDeepCore displacedRegionalTracking in #43472

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable seedingDeepCore displacedRegionalTracking in phase-1 eras #43472

enable seedingDeepCore displacedRegionalTracking in phase-1 eras #43472

slava77 commented Dec 1, 2023 •

edited

Loading

cmsbuild commented Dec 1, 2023

cmsbuild commented Dec 1, 2023

slava77 commented Dec 1, 2023

slava77 commented Dec 1, 2023

cmsbuild commented Dec 1, 2023

cmsbuild commented Dec 1, 2023

slava77 commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

slava77 commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

mandrenguyen commented Dec 4, 2023 •

edited

Loading

antoniovilela commented Dec 4, 2023

cmsbuild commented Dec 4, 2023

smuzaffar commented Dec 6, 2023

enable seedingDeepCore displacedRegionalTracking in phase-1 eras #43472

enable seedingDeepCore displacedRegionalTracking in phase-1 eras #43472

Conversation

slava77 commented Dec 1, 2023 • edited Loading

cmsbuild commented Dec 1, 2023

cmsbuild commented Dec 1, 2023

slava77 commented Dec 1, 2023

slava77 commented Dec 1, 2023

cmsbuild commented Dec 1, 2023

RelVals

RelVals-INPUT

cmsbuild commented Dec 1, 2023

slava77 commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

slava77 commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

Comparison Summary

mandrenguyen commented Dec 4, 2023 • edited Loading

antoniovilela commented Dec 4, 2023

cmsbuild commented Dec 4, 2023

smuzaffar commented Dec 6, 2023

slava77 commented Dec 1, 2023 •

edited

Loading

mandrenguyen commented Dec 4, 2023 •

edited

Loading