-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TH2Poly in DQM Services for HGCal DQM #41932
base: master
Are you sure you want to change the base?
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41932/35885
|
A new Pull Request was created by @ywkao for master. It involves the following packages:
@smuzaffar, @Dr15Jones, @makortel, @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in addition the following places need to be amended accordingly
cmssw/DQMServices/FwkIO/plugins/DQMRootOutputModule.cc
Lines 250 to 253 in e18c96d
static TreeHelperBase* makeHelper(unsigned int iTypeIndex, TTree* iTree, std::string* iFullNameBufferPtr) { | |
switch (iTypeIndex) { | |
case kIntIndex: | |
return new IntTreeHelper(iTree, iFullNameBufferPtr); |
cmssw/DQMServices/FwkIO/plugins/DQMRootSource.cc
Lines 465 to 468 in e18c96d
m_treeReaders[kTProfileIndex].reset(new TreeObjectReader<TProfile>(MonitorElementData::Kind::TPROFILE, m_rescope)); | |
m_treeReaders[kTProfile2DIndex].reset( | |
new TreeObjectReader<TProfile2D>(MonitorElementData::Kind::TPROFILE2D, m_rescope)); | |
} |
How about adding some tests to make sure all the I/O components work properly? (I don't remember if there are already any such tests that could be easily amended)
double lowY, | ||
double highY, | ||
FUNC onbooking = NOOP()) { | ||
return bookME(name, MonitorElementData::Kind::TH2F, [=]() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
return bookME(name, MonitorElementData::Kind::TH2F, [=]() { | |
return bookME(name, MonitorElementData::Kind::TH2Poly, [=]() { |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this should be corrected. I will update it in a commit accordingly.
/// set polygon bin (TH2Poly) | ||
void MonitorElement::addBin(TGraph *graph) { | ||
auto access = this->accessMut(); | ||
static_cast<TH2Poly *>(accessRootObject(access, __PRETTY_FUNCTION__, 2))->AddBin(graph); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the ROOT object is not TH2Poly
? The other similar functions throw an exception via the incompatible()
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, incompatible()
function is necessary. This block of code will be modified as follows:
- static_cast<TH2Poly *>(accessRootObject(access, __PRETTY_FUNCTION__, 2))->AddBin(graph);
+ if (kind() == Kind::TH2Poly) {
+ static_cast<TH2Poly *>(accessRootObject(access, __PRETTY_FUNCTION__, 2))->AddBin(graph);
+ } else {
+ incompatible(__PRETTY_FUNCTION__);
+ }
@@ -140,7 +140,8 @@ struct MonitorElementData { | |||
TH2I = 0x23, | |||
TH3F = 0x30, | |||
TPROFILE = 0x40, | |||
TPROFILE2D = 0x41 | |||
TPROFILE2D = 0x41, | |||
TH2Poly = 0x60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why such a large gap between the previous value (0x41)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I kept thinking of hexagons for a wafer map and then put a number starting with six. We can assign 0x24 for TH2Poly if it is feasible.
+ TH2Poly = 0x24,
TH3F = 0x30,
TPROFILE = 0x40,
- TPROFILE2D = 0x41,
- TH2Poly = 0x60
+ TPROFILE2D = 0x41
type hgcal |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03d614/33112/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41932/35914
|
From #41932 (comment) at least ywkao@002f7cb looks potentially useful (if not necessary) for general usability of |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
if I am not mistaken ywkao@002f7cb still doesn't compile out-of-the-box in the latest CMSSW IB. |
Ok. I checked the ROOT version we have in 14_1_X, and the copy operations for Could @cms-sw/dqm-l2 comment how useful this PR would be without the developments along ywkao@002f7cb ? Or should the basis of the update be
? |
Thank you for bringing this up. Indeed, I missed a few commits. I confirmed that the method https://github.com/ywkao/cmssw/commits/dev_th2poly_MEtoEDMFormat |
The additional commits in dev_th2poly_MEtoEDMFormat patch the functionality of DQMServices
DataFormats/Histograms
|
Hi @makortel and @mmusich, the missing parts are patched in the same branch, dev_th2poly_MEtoEDMFormat, except for the script I still need to think how to address the issue. I will investigate the issue early next week. If you have any suggestions or comments, I would appreciate your input. [1] https://ykao.web.cern.ch/ykao/raw_data_handling/pull_request_cmssw/log_20240823.txt
|
It seems to me the call to
via
but from just browsing the code I didn't spot anything obviously wrong. |
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
Thank you for your input last Friday. I apologize for the delay in getting back to you. In fact, TH2Poly::Add() takes two arguments instead of one, as shown below (definition here)
So, L115 might cause some problems. However, the following modification does not resolve the segmentation fault after compilation. The error messages are the same. - 115 original->Add(toAdd);
+ 115 original->Add(toAdd, 1.); The situation seems similar to the implementation for Commands with harvesters turned off also generated the same errors:
I also suspected that TH2Poly objects might need to be set up with Let me know if you have any ideas on this issue. |
We would like to propose bypassing the TH2Poly when merging the monitor elements. +204 if(existing->kind() == MonitorElementData::Kind::TH2Poly) return;
205 DQMMergeHelper::mergeTogether(existing->getTH1(), m_buffer); |
I'd suggest to report this problem to ROOT team e.g. by opening an issue in https://github.com/root-project/root/. Also FYI @pcanal |
I have made a pull request to ROOT: root-project/root#16370 |
Hi @makortel, the PR root-project/root#16370 has been merged. We need core software people to help update the ROOT version in CMSSW to incorporate this feature. |
That PR was already included in the latest ROOT master IB update (cms-sw/cmsdist#9476), and will be part of the next CMSSW_14_2_ROOT6_X IB. Could you (or someone else) ask the ROOT PR to be backported to 6.32 and 6.30 branches? |
The backports to 6.32 and 6.30 have been merged: |
@smuzaffar Could we get these PRs included in our default and 6.32 ROOT builds? |
ROOT6.30: cms-sw/cmsdist#9479 |
PR description:
This PR introduces a new type of DQM MonitorElement, TH2Poly, for HGCal DQM in the future. This feature allows a display of polygonal histograms on the CMS DQM GUI. As a demonstration, a wafer map can be displayed like the screenshot here [1].
TH2Poly is a 2D histogram class inherited from TH2. Polygonal bins, defined by TGraph, can be loaded using the AddBin() method. After setting up the polygonal bins, a TH2Poly object can store information through Fill() or SetBinContent().
A workflow for creating polygonal histograms looks like this:
DQM Service -> DQM EDAnalyzer -> CMS DQM GUI
An implementation of TH2Poly in DQM Service and MonitorElement is necessary to display the polygonal histograms. It involves updates on two repositories: cmssw and dqmgui_prod. A pull request is created in the dqmgui_prod repository [2] with a relevant issue reported in this link [3], which is about setting up a CMS DQM GUI with the new feature.
PR validation:
The workflow and the implementation have been tested: (a) From this feature branch, monitor elements of TH2Poly can be stored in a DQM root file [4]. (b) The DQM root file can be uploaded to a CMS DQM GUI, which is built following the steps noted in this issue [3]. Polygonal maps can be displayed on the DQM GUI, as demonstrated in [1].
[1] https://ykao.web.cern.ch/ykao/raw_data_handling/hgcal_dqm_gui/screenshot_demo_th2poly_wafermap.png
[2] cms-DQM/dqmgui_prod#14
[3] cms-DQM/dqmgui_prod#13
[4] A DQM root file containing demo polygonal maps: /afs/cern.ch/work/y/ykao/public/example_HGCAL_DQM/DQM_V0001_HGCAL_R000123469.root