Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL DQM small fixes of problems experienced during MWGR2 #13543

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

vkhristenko
Copy link
Contributor

resubmitting on top of the updated 80X since it wouldn't merge.
I closed previous PR because I didn't really know based from where to rebase. Just merging CMSSW80X branch showed a large number of commits... may be there was a better way...

VK

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

A new Pull Request was created by @vkhristenko (Viktor Khristenko) for CMSSW_8_0_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks
DQMOffline/Configuration

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

please test

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@davidlange6
Copy link
Contributor

@vkhristenko - please give this PR a meaningful name for the release notes. Thanks

@vkhristenko vkhristenko changed the title redoing 13412 on top of 80X HCAL DQM small fixes of problems experienced during MWGR2 Mar 2, 2016
@vkhristenko
Copy link
Contributor Author

@davidlange6 - done

davidlange6 added a commit that referenced this pull request Mar 2, 2016
HCAL DQM small fixes of problems experienced during MWGR2
@davidlange6 davidlange6 merged commit a75a09e into cms-sw:CMSSW_8_0_X Mar 2, 2016
@Martin-Grunewald
Copy link
Contributor

Hi,

This PR in 81X (was auto ported to 81X) seems to create a problem in 81X,
with this error message:

----- Begin Fatal Exception 03-Mar-2016 07:38:05 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 2 event: 301
   [1] Running path 'validation_step'
   [2] Calling event method for module MultiTrackValidator/'hiTrackValidator'
Exception Message:
Efficiency and fake TrackingParticle (refs) point to different collections (eff 3:256 fake 3:254). This is not supported. Efficiency TP set must be the same or a subset of the fake TP set.
----- End Fatal Exception -------------------------------------------------

It is a cmsDriver generated workflow:

# Auto generated configuration file
# using: 
# Revision: 1.19 
# Source: /local/reps/CMSSW/CMSSW/Configuration/Applications/python/ConfigBuilder.py,v 
# with command line options: RelVal --step=RAW2DIGI,L1Reco,RECO,VALIDATION,DQM --conditions=auto:run2_mc_HIon --filein=file:RelVal_DigiL1RawHLT_HIon_MC.root --custom_conditions= --fileout=RelVal_RECO_HIon_MC.root --number=25 --mc --no_exec --datatier SIM-RAW-HLT-RECO --eventcontent=RAW --customise=HLTrigger/Configuration/CustomConfigs.Base --era=Run2_HI --customise= --scenario=HeavyIons --python_filename=RelVal_RECO_HIon_MC.py --processName=RECO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants