Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge: Add %define disable_tf_mkldnn = 1 to tensorflow spec #9471

Open
wants to merge 3 commits into
base: IB/CMSSW_14_2_X/master
Choose a base branch
from

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 17, 2024

Change enable_tf_mkldnn to disable_tf_mkldnn since the bazel build option defaults to 1 and must be explicitly set to 0.
https://github.com/tensorflow/tensorflow/blob/8e2b6655c0c488290179ab90a0daed0f6d3006f7/tensorflow/core/kernels/BUILD#L79-L89

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung for branch IB/CMSSW_14_2_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2024

cms-bot internal usage

@gartung gartung changed the title Add %define enable_tf_mkldnn =1 to tensor flow build Do not merge: Add %define enable_tf_mkldnn =1 to tensor flow build Oct 17, 2024
@gartung
Copy link
Member Author

gartung commented Oct 17, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a614/42275/summary.html
COMMIT: fadfa0b
CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9471/42275/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a614/42275/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a614/42275/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
332.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 6 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 23780 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3335129
  • DQMHistoTests: Total failures: 30053
  • DQMHistoTests: Total nulls: 16
  • DQMHistoTests: Total successes: 3305040
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.06999999999999998 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 140.023 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.043 ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.031 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.004 KiB JetMET/SUSYDQM
  • Checked 197 log files, 167 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 3 / 42 workflows

@cmsbuild
Copy link
Contributor

Pull request #9471 was updated.

@cmsbuild
Copy link
Contributor

Pull request #9471 was updated.

@gartung
Copy link
Member Author

gartung commented Oct 25, 2024

please test

@gartung gartung changed the title Do not merge: Add %define enable_tf_mkldnn =1 to tensor flow build Do not merge: Add %define disable_tf_mkldnn = 1 to tensorflow spec Oct 25, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a614/42395/summary.html
COMMIT: d95ddcc
CMSSW: CMSSW_14_2_X_2024-10-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9471/42395/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 502 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565613
  • DQMHistoTests: Total failures: 7439
  • DQMHistoTests: Total nulls: 34
  • DQMHistoTests: Total successes: 3558120
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 444.59700000000004 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -1.018 KiB HLT/Filters
  • DQMHistoSizes: changed ( 332.0 ): 451.723 KiB HLT/Filters
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants