Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] Update to version 18.1.6 #9200

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

smuzaffar
Copy link
Contributor

Updating LLVM version to 18.1.6

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 21, 2024

test parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39451/summary.html
COMMIT: d1da409
CMSSW: CMSSW_14_1_CLANG_X_2024-05-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39451/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

[3405/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/llvm-profdata -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/llvm-profdata -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/llvm-profdata/CMakeFiles/llvm-profdata.dir/llvm-profdata.cpp.o -MF tools/llvm-profdata/CMakeFiles/llvm-profdata.dir/llvm-profdata.cpp.o.d -o tools/llvm-profdata/CMakeFiles/llvm-profdata.dir/llvm-profdata.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/llvm-profdata/llvm-profdata.cpp
[3406/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/dsymutil/CMakeFiles/dsymutil.dir/MachOUtils.cpp.o -MF tools/dsymutil/CMakeFiles/dsymutil.dir/MachOUtils.cpp.o.d -o tools/dsymutil/CMakeFiles/dsymutil.dir/MachOUtils.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil/MachOUtils.cpp
[3407/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/dsymutil/CMakeFiles/dsymutil.dir/dsymutil.cpp.o -MF tools/dsymutil/CMakeFiles/dsymutil.dir/dsymutil.cpp.o.d -o tools/dsymutil/CMakeFiles/dsymutil.dir/dsymutil.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil/dsymutil.cpp
[3408/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/dsymutil/CMakeFiles/dsymutil.dir/DwarfLinkerForBinary.cpp.o -MF tools/dsymutil/CMakeFiles/dsymutil.dir/DwarfLinkerForBinary.cpp.o.d -o tools/dsymutil/CMakeFiles/dsymutil.dir/DwarfLinkerForBinary.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Mq0uPy (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+llvm+18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b
Macro expanded in comment on line 368: %{pkginstroot}/lib64


@smuzaffar
Copy link
Contributor Author

@gartung , I am testing llvm 18.1.6 and it failed due to cms checker.

external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/include/clang/AST/../Basic/Attr.td:734:57: error: Expected a class name, got 'C2x'
  let Spellings = [ CXX11<"cms","thread_safe", 200809>, C2x<"cms", "thread_safe"> ];                                                        ^

Can you please look in to this and provide a fix for https://github.com/cms-externals/llvm-project/tree/cms/release/18.x/1118c2e

@smuzaffar
Copy link
Contributor Author

please test with cms-externals/llvm-project#14 for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39457/summary.html
COMMIT: d1da409
CMSSW: CMSSW_14_1_CLANG_X_2024-05-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39457/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/tools/include-what-you-use/iwyu_ast_util.h:339:5: note: in expansion of macro 'CHECK_UNREACHABLE_'
339 |     CHECK_UNREACHABLE_("Unknown kind");
|     ^~~~~~~~~~~~~~~~~~
[5646/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -DIWYU_GIT_REV=\"\" -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/build/tools/clang/tools/include-what-you-use -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/tools/include-what-you-use -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/build/tools/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/tools/include-what-you-use/CMakeFiles/include-what-you-use.dir/iwyu_ast_util.cc.o -MF tools/clang/tools/include-what-you-use/CMakeFiles/include-what-you-use.dir/iwyu_ast_util.cc.o.d -o tools/clang/tools/include-what-you-use/CMakeFiles/include-what-you-use.dir/iwyu_ast_util.cc.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/tools/include-what-you-use/iwyu_ast_util.cc
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.NuGawQ (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+llvm+18.1.6-84cebedcc15589e75ae9e728d5113e2f
Macro expanded in comment on line 368: %{pkginstroot}/lib64


@cmsbuild
Copy link
Contributor

Pull request #9200 was updated.

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@makortel
Copy link
Contributor

makortel commented Jun 3, 2024

18 src/RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CalorimeterDefinitions.h(108): warning #68-D: integer conversion resulted in a change of sign

Probably change this line to read return static_cast<uint32_t>(-1);?

I'd say returning std::numeric_limits<uint32_t>::max() would be easier to understand.

    699  use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
    150  use of NaN is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]

We are building cmssw with -ffast-math, which sets (among other flags) -ffinite-math-only, allowing compiler to assume all floating-point numbers will be finite (no NaNs or infinities), but some functions explicitly return std::numeric_limits<float>::infinity and std::numeric_limits<float>::quiet_NaN. We can try adding -fno-finite-math-only flag and checking if that hurts performance or not.

We have edm::isNotFinite() to be used with -ffast-math, that we are suggesting instead of std::isinf() and std::isnan() in the static analyzer.

(disallowing -ffast-math, which would have many benefits, would need to be a discussion separate from this PR)

  4281  variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]

This means that code like

bool used[n];

is not a valid ISO C++ code. We can either silence this warning, or replace all such instances with std::vectors

std::vector<bool> used(n);

Moving away from VLAs (which would have its benefits) would need to be a separate discussion. See cms-sw/cmssw#44937 for some recent discussion. Maybe in some places the cost of dynamic memory allocation is negligible, but there are places where it has (or had) noticeable performance impact.

@iarspider
Copy link
Contributor

@makortel

We have edm::isNotFinite() to be used with -ffast-math, that we are suggesting instead of std::isinf() and std::isnan() in the static analyzer.

clang is not complaining about std::isnan or std::isinf checks, but about explicitly using std::numeric_limits<float>::infinity and std::numeric_limits<float>::quiet_NaN, see e.g. ElectronSeed

    void setNegAttributes(const float dRZ2 = std::numeric_limits<float>::infinity(),
                          const float dPhi2 = std::numeric_limits<float>::infinity(),
                          const float dRZ1 = std::numeric_limits<float>::infinity(),
                          const float dPhi1 = std::numeric_limits<float>::infinity());
    void setPosAttributes(const float dRZ2 = std::numeric_limits<float>::infinity(),
                          const float dPhi2 = std::numeric_limits<float>::infinity(),
                          const float dRZ1 = std::numeric_limits<float>::infinity(),
                          const float dPhi1 = std::numeric_limits<float>::infinity());

@makortel
Copy link
Contributor

makortel commented Jun 3, 2024

We have edm::isNotFinite() to be used with -ffast-math, that we are suggesting instead of std::isinf() and std::isnan() in the static analyzer.

clang is not complaining about std::isnan or std::isinf checks, but about explicitly using std::numeric_limits<float>::infinity and std::numeric_limits<float>::quiet_NaN

Ah, ok. Maybe we should replace such comparisons as well with edm::isNotFinite (under the assumption we continue to use -ffast-math.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

Pull request #9200 was updated.

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

-1

Failed Tests: UnitTests AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39720/summary.html
COMMIT: be58d37
CMSSW: CMSSW_14_1_CLANG_X_2024-06-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39720/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

AddOn Tests

----- Begin Fatal Exception 05-Jun-2024 21:10:29 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /pool/condor/dir_1590122/jenkins/workspace/ib-run-pr-addon/CMSSW_14_1_CLANG_X_2024-06-03-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py
Exception Message:
 unknown python problem occurred.
ModuleNotFoundError: No module named 'past'

At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39720/CMSSW_14_1_CLANG_X_2024-06-03-2300/src/FWCore/ParameterSet/python/Types.py(6): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39720/CMSSW_14_1_CLANG_X_2024-06-03-2300/src/FWCore/ParameterSet/python/Config.py(16): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /pool/condor/dir_1590122/jenkins/workspace/ib-run-pr-addon/CMSSW_14_1_CLANG_X_2024-06-03-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py(2): <module>

----- End Fatal Exception -------------------------------------------------
[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 0 sec (ended on Wed Jun  5 21:10:33 2024) - exit: 256
[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 0 sec (ended on Wed Jun  5 21:10:38 2024) - exit: 256
Expand to see more addon errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39738/summary.html
COMMIT: be58d37
CMSSW: CMSSW_14_1_CLANG_X_2024-06-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39738/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

RelVals

AddOn Tests

----- Begin Fatal Exception 06-Jun-2024 13:12:37 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /data/cmsbld/jenkins/workspace/ib-run-pr-addon/CMSSW_14_1_CLANG_X_2024-06-05-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py
Exception Message:
 unknown python problem occurred.
ModuleNotFoundError: No module named 'past'

At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39738/CMSSW_14_1_CLANG_X_2024-06-05-2300/src/FWCore/ParameterSet/python/Types.py(6): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39738/CMSSW_14_1_CLANG_X_2024-06-05-2300/src/FWCore/ParameterSet/python/Config.py(16): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /data/cmsbld/jenkins/workspace/ib-run-pr-addon/CMSSW_14_1_CLANG_X_2024-06-05-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py(2): <module>

----- End Fatal Exception -------------------------------------------------
[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 0 sec (ended on Thu Jun  6 13:12:41 2024) - exit: 256
[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 0 sec (ended on Thu Jun  6 13:12:42 2024) - exit: 256
Expand to see more addon errors ...

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Jun 6, 2024

looks good, lets get this in next CLANG IB

@smuzaffar smuzaffar merged commit 0abfb53 into IB/CMSSW_14_1_X/clang Jun 6, 2024
8 of 10 checks passed
@smuzaffar smuzaffar deleted the llvm-18.1.6 branch June 6, 2024 20:05
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39753/summary.html
COMMIT: be58d37
CMSSW: CMSSW_14_1_CLANG_X_2024-06-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9200/39753/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39753/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39753/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

  • You potentially added 14069 lines to the logs
  • Reco comparison results: 30373 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 289677
  • DQMHistoTests: Total nulls: 154
  • DQMHistoTests: Total successes: 3049123
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.026999999999999993 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 4 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants