Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tf_cuda_support tool if TF is build with cuda support #9066

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 12, 2024

Following up cms-sw/cmssw#44376 , this PR adds a new tool tf_cuda_support which will only be available in cmssw if TF is build with cuda/gpu support. One can use this tools to conditionally build/run cmssw tests which require TF GPU support.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

cms-bot internal usage

tensorflow.spec Outdated Show resolved Hide resolved
Co-authored-by: Matti Kortelainen <[email protected]>
@cmsbuild
Copy link
Contributor

Pull request #9066 was updated.

@smuzaffar
Copy link
Contributor Author

please test
thanks @makortel for extra eyes :-)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac91bd/38086/summary.html
COMMIT: 6f61f29
CMSSW: CMSSW_14_1_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9066/38086/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac91bd/38086/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac91bd/38086/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 115 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2819 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 5668
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3291695
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.011 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.011 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@smuzaffar
Copy link
Contributor Author

+externals

Note that as currently TF is build with GPU support so this new tool will not be available in cmssw

@smuzaffar smuzaffar merged commit 54a5f9c into IB/CMSSW_14_1_X/master Mar 13, 2024
9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the added-tf_cuda_support branch March 14, 2024 15:40
@cmsbuild
Copy link
Contributor

backport done
Successfully backported PR #9066 as #9077 for branch IB/CMSSW_14_0_X/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants