Add resources-diff.py. Run script on FastTimerService resources.json output of PR versus IB release. #2343

gartung · 2024-09-25T15:28:18Z

No description provided.

…R versus IB release.

cmsbuild · 2024-09-25T15:28:42Z

A new Pull Request was created by @gartung for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-09-25T15:28:43Z

cms-bot internal usage

cmsbuild · 2024-09-25T15:30:32Z

Pull request #2343 was updated.

gartung · 2024-09-25T15:30:47Z

enable profiling

gartung · 2024-09-25T15:31:08Z

please test

pr_testing/run-pr-profiling.sh

cmsbuild · 2024-09-25T15:39:26Z

Pull request #2343 was updated.

gartung · 2024-09-25T15:39:47Z

please test

cmsbuild · 2024-09-25T20:28:48Z

Pull request #2343 was updated.

gartung · 2024-09-25T21:23:15Z

please test

cmsbuild · 2024-09-26T00:31:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e18c1/41754/summary.html
COMMIT: e961154
CMSSW: CMSSW_14_2_X_2024-09-25-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2343/41754/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 83 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331342
DQMHistoTests: Total failures: 2878
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328444
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

gartung · 2024-09-30T21:27:43Z

please test

…. Add links to profiling workflow summary.

cmsbuild · 2024-10-01T00:37:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e18c1/41822/summary.html
COMMIT: 003f4d1
CMSSW: CMSSW_14_2_X_2024-09-30-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2343/41822/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 36 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331342
DQMHistoTests: Total failures: 2242
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3329080
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-10-01T00:49:35Z

Pull request #2343 was updated.

cmsbuild · 2024-10-01T00:50:35Z

Pull request #2343 was updated.

gartung · 2024-10-01T00:51:08Z

please test

cmsbuild · 2024-10-01T04:09:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e18c1/41823/summary.html
COMMIT: 4469cbf
CMSSW: CMSSW_14_2_X_2024-09-30-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2343/41823/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 126 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331342
DQMHistoTests: Total failures: 4379
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3326943
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-10-01T12:14:42Z

@gartung , is this ready to go in?

gartung · 2024-10-01T12:37:34Z

Almost. I need to correct the links on the profiling summary page.

smuzaffar · 2024-10-01T12:39:15Z

ping me when it is ready

cmsbuild · 2024-10-01T13:17:45Z

Pull request #2343 was updated.

gartung · 2024-10-01T13:17:50Z

@smuzaffar it should be ready to go.

Add resources-diff.py. Run script on FastTimerServer json output of P…

fb0a73c

…R versus IB release.

cmsbuild added the orp-pending label Sep 25, 2024

cmsbuild added pending-signatures externals-pending tests-pending labels Sep 25, 2024

Black formatting

01ffadf

cmsbuild added tests-started and removed tests-pending labels Sep 25, 2024

smuzaffar reviewed Sep 25, 2024

View reviewed changes

pr_testing/run-pr-profiling.sh Outdated Show resolved Hide resolved

Add || true in case of failure

e13e720

cmsbuild added tests-pending and removed tests-started labels Sep 25, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 25, 2024

Filename has directory in it

e961154

cmsbuild added tests-pending and removed tests-started labels Sep 25, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 25, 2024

cmsbuild removed the tests-started label Sep 26, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2024

Add background color for thread time percent diff exceeding threshold…

c500406

…. Add links to profiling workflow summary.

cmsbuild added tests-approved tests-pending and removed tests-started tests-approved labels Oct 1, 2024

Black formatting

4469cbf

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 1, 2024

Fix link to resources diff summary html

cc86115

cmsbuild added tests-pending and removed tests-approved labels Oct 1, 2024

smuzaffar merged commit 1f8aae7 into cms-sw:master Oct 1, 2024
3 of 4 checks passed

gartung deleted the gartung-resouces-diff branch October 1, 2024 14:10

This was referenced Oct 1, 2024

ticl: Optimize calculation of Trackster time cms-sw/cmssw#46133

Merged

Redesign of the association maps, multivector manager, HGCAL Rechits and Validation with significant speedup of Phase-2 workflows cms-sw/cmssw#45865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add resources-diff.py. Run script on FastTimerService resources.json output of PR versus IB release. #2343

Add resources-diff.py. Run script on FastTimerService resources.json output of PR versus IB release. #2343

gartung commented Sep 25, 2024

cmsbuild commented Sep 25, 2024

cmsbuild commented Sep 25, 2024 •

edited

Loading

cmsbuild commented Sep 25, 2024

gartung commented Sep 25, 2024

gartung commented Sep 25, 2024

cmsbuild commented Sep 25, 2024

gartung commented Sep 25, 2024

cmsbuild commented Sep 25, 2024

gartung commented Sep 25, 2024

cmsbuild commented Sep 26, 2024

gartung commented Sep 30, 2024

cmsbuild commented Oct 1, 2024

cmsbuild commented Oct 1, 2024

cmsbuild commented Oct 1, 2024

gartung commented Oct 1, 2024

cmsbuild commented Oct 1, 2024

smuzaffar commented Oct 1, 2024

gartung commented Oct 1, 2024

smuzaffar commented Oct 1, 2024

cmsbuild commented Oct 1, 2024

gartung commented Oct 1, 2024

Add resources-diff.py. Run script on FastTimerService resources.json output of PR versus IB release. #2343

Add resources-diff.py. Run script on FastTimerService resources.json output of PR versus IB release. #2343

Conversation

gartung commented Sep 25, 2024

cmsbuild commented Sep 25, 2024

cmsbuild commented Sep 25, 2024 • edited Loading

cmsbuild commented Sep 25, 2024

gartung commented Sep 25, 2024

gartung commented Sep 25, 2024

cmsbuild commented Sep 25, 2024

gartung commented Sep 25, 2024

cmsbuild commented Sep 25, 2024

gartung commented Sep 25, 2024

cmsbuild commented Sep 26, 2024

Comparison Summary

gartung commented Sep 30, 2024

cmsbuild commented Oct 1, 2024

Comparison Summary

cmsbuild commented Oct 1, 2024

cmsbuild commented Oct 1, 2024

gartung commented Oct 1, 2024

cmsbuild commented Oct 1, 2024

Comparison Summary

smuzaffar commented Oct 1, 2024

gartung commented Oct 1, 2024

smuzaffar commented Oct 1, 2024

cmsbuild commented Oct 1, 2024

gartung commented Oct 1, 2024

cmsbuild commented Sep 25, 2024 •

edited

Loading