Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Disable checking for number of modified files in non-cmssw repos #2323

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

iarspider
Copy link
Contributor

@smuzaffar I think this change makes sense - we only need to check what files were touched to determine what L2 signatures the PR needs, right?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

cms-bot internal usage

@iarspider iarspider changed the title [RFQ] Disable checking for number of modified files in non-cmssw repos [RFC] Disable checking for number of modified files in non-cmssw repos Aug 27, 2024
@iarspider
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Aug 27, 2024
@iarspider iarspider merged commit 9fa672d into master Sep 3, 2024
8 of 9 checks passed
@iarspider iarspider deleted the no-file-limit-root branch September 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants