Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for process_pr script #2266

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Unit tests for process_pr script #2266

merged 1 commit into from
Jun 26, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Jun 21, 2024

test parameters:

  • skip_test = static,header

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@cmsbuild, @iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@smuzaffar
Copy link
Contributor

ping bot

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test for CMSSW_5_3_X

test it for slc6 IB

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

4 similar comments
@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2266 was updated.

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

please test for CMSSW_5_3_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-933b9f/40073/summary.html
COMMIT: 5dda5f9
CMSSW: CMSSW_5_3_X_2024-06-23-0000/slc6_amd64_gcc472
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2266/40073/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 25-Jun-2024 15:38:55 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Input file file:step2.root was not found, could not be opened, or is corrupted.
   Additional Info:
      [a] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 25-Jun-2024 15:39:06 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Input file file:step2.root was not found, could not be opened, or is corrupted.
   Additional Info:
      [a] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 25-Jun-2024 15:39:28 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Input file file:step2.root was not found, could not be opened, or is corrupted.
   Additional Info:
      [a] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-933b9f/40072/summary.html
COMMIT: 5dda5f9
CMSSW: CMSSW_14_1_X_2024-06-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2266/40072/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345059
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

looks good

@smuzaffar smuzaffar merged commit 4dfaddb into master Jun 26, 2024
21 of 22 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider deleted the process-pr-unit-tests-4 branch June 26, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants