Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset all labels on commit #2110

Merged
merged 46 commits into from
Dec 13, 2023
Merged

Do not reset all labels on commit #2110

merged 46 commits into from
Dec 13, 2023

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

A new Pull Request was created by @iarspider for branch master.

@cmsbuild, @smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

Pull request #2110 was updated.

pyproject.toml Outdated Show resolved Hide resolved
process_pr.py Outdated Show resolved Hide resolved
process_pr.py Outdated Show resolved Hide resolved
process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@iarspider
Copy link
Contributor Author

NB: Have not yet tested last changes properly.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

process_pr.py Outdated
# for fn in event["value"]:
# chg_categories.update(
# get_package_categories(cmssw_file2Package(repo_config, fn))
# )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider , shouldn't we reset the signature for the cats touched by this commit?

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

process_pr.py Outdated Show resolved Hide resolved
process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@smuzaffar
Copy link
Contributor

I am getting this error

> ./process-pull-request -n -r cms-sw/cmssw 11963
....
....
Traceback (most recent call last):
  File "./process-pull-request", line 83, in <module>
    process_pr(repo_config, gh, repo, repo.get_issue(prId), opts.dryRun, force=opts.force)
  File "/build/muz/bot/cms-bot/process_pr.py", line 1444, in process_pr
    get_package_categories(cmssw_file2Package(repo_config, fn))
ValueError: dictionary update sequence element #0 has length 14; 2 is required

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@smuzaffar
Copy link
Contributor

can you please run bit more tests

> ./process-pull-request -n -r cms-sw/cmssw 43543
DRY RUN: Updating existing comment with text
Traceback (most recent call last):
  File "./process-pull-request", line 83, in <module>
    process_pr(repo_config, gh, repo, repo.get_issue(prId), opts.dryRun, force=opts.force)
  File "/build/muz/bot/cms-bot/process_pr.py", line 1406, in process_pr
    print(new_body)
UnicodeEncodeError: 'ascii' codec can't encode character '\u0144' in position 62: ordinal not in range(128)

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2110 was updated.

@smuzaffar
Copy link
Contributor

+externals
This looks good now. I have tested it for various existsing PRs and cms-sw/cmssw#43552. I will merge it tomorrow morning

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

There are too many commits so I will squash and merge this PR

@smuzaffar smuzaffar merged commit c891df4 into master Dec 13, 2023
3 of 4 checks passed
@iarspider iarspider deleted the partial-reset-2 branch December 13, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants