Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow assigning of categories using package name #2092

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

smuzaffar
Copy link
Contributor

This change should allow bot to use cmssw package names to assign categories to an issue e.g. following comments should allow bot to properly assign L2 categories to an issue

assign|unassign Package/Name[,Package/Name[...]]
assign|unassign from Package/Name[,Package/Name[...]]
assign|unassign package Package/Name[,Package/Name[...]]

@Dr15Jones requested this feature and I agree that it is very useful (avoid doing a lookup in https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to find the package/category mapping)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

+externals

local tests look good for cms-sw/cmssw#43009 (comment)

> ./process-pull-request -n 43009
...
==> assign CondCore/CondDB,MagneticField/Interpolation,DataFormats/Common assign ['db', 'reconstruction', 'core']
==> unassign DataFormats/Common unassign ['core']
...

@smuzaffar smuzaffar merged commit 1d407d6 into master Oct 18, 2023
2 of 3 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the bot-package-cat-assign branch October 18, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants