Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update categories.py for pdmv #2032

Closed
wants to merge 1 commit into from
Closed

Update categories.py for pdmv #2032

wants to merge 1 commit into from

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Aug 9, 2023

Add Adriano and Mikko to the pdmv category

Add Adriano and Mikko to the pdmv category
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2023

A new Pull Request was created by @perrotta (Andrea Perrotta) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Aug 9, 2023

+1

@@ -52,6 +52,7 @@
"clacaputo": ["reconstruction"],
"kskovpen": ["pdmv"],
"sunilUIET": ["pdmv"],
"miquork": ["pdmv"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrotta , miquork is already defined at

"miquork": ["jetmet-pog"],
, please remove it from here and add "pdmv" at
"miquork": ["jetmet-pog"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I did not notice!

@@ -65,7 +66,7 @@
"aloeliger": ["l1"],
"rvenditti": ["dqm"],
"syuvivida": ["dqm"],
"tjavaid": ["dqm"],
"tjavaid": ["dqm"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove the extra space from here?

@perrotta perrotta closed this Aug 9, 2023
@perrotta perrotta deleted the pdmv2023 branch August 9, 2023 13:05
@perrotta
Copy link
Contributor Author

perrotta commented Aug 9, 2023

Moved to #2033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants