Make all methods' return values uniform #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically instead of responses, the package will now try to parse the response, run json() and return a dict, or list of dicts. Exceptions are now raised in case of insufficient permissions.
nothingface0
changed the title
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
nothingface0
force-pushed
the
uniform_return_values
branch
from
b1886ae
to
8ec4ac4
Compare
Invalid inputs usually raise a ValueError, AFAIK. Generic Exceptions are kept for permission errors. TODO: Maybe create a custom Exception for the latter case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runregistrymethods, instead of returningrequest.Response, will now try to parse them, run json() and return a dict, or list of dicts. Exceptions are now raised in case of insufficient permissions. Previously, the return values were different for each method, others beingrequest.Response(or lists of those),dicts, or lists ofdicts.