Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lumisections/joint_lumisection_ranges endpoint ignoring dataset_name when fetching oms lumisections #26

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

gabrielmscampos
Copy link
Member

When the DC expert recovers DCS bits in Offline Run Registry, those entries aren't updated in the OMS online dataset but instead in the specific dataset the operation was targeted.

Right now, if you inspect the "OMS LUMISECTIONS" tab for an Offline dataset, the DCS bits are different from the "BOTH" tab.

@nothingface0
Copy link
Contributor

For completion and future reference, this endpoint (joint_lumisection_ranges) is an aggregate of oms_lumisection_ranges and rr_lumisection_ranges.

Those are used mostly in the frontend, in the modal that appears when clicking LS (next to Manage) for a specific run.

The OMS LUMISECTIONS button uses oms_lumisection_ranges, the RR LUMISECTIONS uses the rr_lumisection_ranges and the BOTH button uses the joint_lumisection_ranges. All calls to each endpoint from the frontend are passed the dataset argument, but the joint_lumisection_ranges was ignoring it, always using online instead. This was probably not the intended functionality.

@nothingface0 nothingface0 merged commit 4137ea0 into cms-DQM:master Oct 1, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants