fix: invalid device state after bind #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediately call for as state update as soon as the device is bound, add a signal that can be used to check that the device has received it's first state update.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 95.75% 95.79% +0.04%
==========================================
Files 8 8
Lines 730 737 +7
==========================================
+ Hits 699 706 +7
Misses 31 31 ☔ View full report in Codecov by Sentry. |
Add test for request_version with timeout
cmroche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately call for as state update as soon as the device is bound, add a signal that can be used to check that the device has received it's first state update.
Removed unused, optional, wait_for parameter on update_state and send_device_state
CLOSES #99