unix: Fix user after free when clearing a file handle

The iod may go away in the cleared handler, so don't use it after that point. Signed-off-by: Corey Minyard <[email protected]>
cminyard · Jan 4, 2025 · 25ec586 · 25ec586
1 parent 2d9c25a
commit 25ec586
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/os_unix.c b/lib/os_unix.c
@@ -566,9 +566,9 @@ file_runner(struct gensio_runner *r, void *cb_data)
 	iod->handlers_set = false;
 	f->unlock(iod->u.file.lock);
 	iod->cleared_handler(&iod->r, iod->cb_data);
-	f->lock(iod->u.file.lock);
+    } else {
+	f->unlock(iod->u.file.lock);
     }
-    f->unlock(iod->u.file.lock);
 }
 
 static void