Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sniffing #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add sniffing #42

wants to merge 2 commits into from

Conversation

pingz
Copy link

@pingz pingz commented Mar 22, 2018

turn on sniffing as in issue #41 .

@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

Merging #42 into master will increase coverage by 1.06%.
The diff coverage is 52.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   82.78%   83.85%   +1.06%     
==========================================
  Files           2        2              
  Lines         151      161      +10     
  Branches       18       17       -1     
==========================================
+ Hits          125      135      +10     
  Misses         22       22              
  Partials        4        4
Impacted Files Coverage Δ
cmreslogging/handlers.py 83.11% <52.17%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6765a24...834dcc6. Read the comment docs.

@cmanaha
Copy link
Owner

cmanaha commented Mar 22, 2018

Thanks for the contrib. I'll add things up (both pr's) and get them merged over the weekend (would like to check if there is any other test around sniff that we should run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants