Should msg also be included in filter fields?
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`msg` is not included in logging.Formatter documents, and will be included in the elasticsearch message body, as you're not excluding it here. If you using this handler just for one specific logger statement, it is fine. If you want to apply it to global logger, and there will be various types of `msg` coexisted, then elasticsearch will drop some messages because of that.
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 82.78% 82.78%
=======================================
Files 2 2
Lines 151 151
Branches 18 18
=======================================
Hits 125 125
Misses 22 22
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msgis not included in logging.Formatter documents, and will be included in the elasticsearch message body, as you're not excluding it here. If you using this handler just for one specific logger statement, it is fine. If you want to apply it to global logger, and there will be various types ofmsgcoexisted, then elasticsearch will drop some messages because of that.