Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see if we can build rustls deps with aws-lc
closes #141
We don't need to do anything.
Updating tests is enough. Example taken from hyper-rustls
It works out of the box because the
aws-lc-sys
crate just works and passes tests provided i actually update rustls in the test suite.Notes on Compiling
pointless log of my exploration of actually compiling it.
building it from docker
avoided by not doing any linking in the build (turning off tool, libssl build and test builds)
for posterity the following invocation does at least compile in the image
/bin/sh: 1: ninja-build: not found despite apt installing ninja-build
is there under different name:
using
ninja
overninja-build
./usr/bin/ld: cannot find -lgcc_s: No such file or directory
avoided by not doing any linking in the build (turning off tool, libssl build and test builds)
dropping go dep
seems to be a build time dep that we can drop according to
https://github.com/aws/aws-lc/blob/dc3b44be65ac29fc1999ab2aad2d06c64f7525b6/BUILDING.md?plain=1#L217-L225
didn't try.