Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lc tests #152

Merged
merged 3 commits into from
Feb 26, 2025
Merged

aws-lc tests #152

merged 3 commits into from
Feb 26, 2025

Conversation

clux
Copy link
Owner

@clux clux commented Feb 25, 2025

To see if we can build rustls deps with aws-lc
closes #141

We don't need to do anything.

Updating tests is enough. Example taken from hyper-rustls

It works out of the box because the aws-lc-sys crate just works and passes tests provided i actually update rustls in the test suite.

Notes on Compiling

pointless log of my exploration of actually compiling it.

building it from docker

avoided by not doing any linking in the build (turning off tool, libssl build and test builds)

for posterity the following invocation does at least compile in the image

# ADD: apt-get install -y ninja-build golang-go
# THEN DL + COMPILE:
RUN curl -sSL https://github.com/aws/aws-lc/archive/refs/tags/v${AWS_LC_VER}.tar.gz | tar xz && \
    mkdir aws-lc-build && cd aws-lc-build && \
    cmake -GNinja \
        -DCMAKE_BUILD_TYPE=RelWithDebInfo \
        -DCMAKE_INSTALL_PREFIX=$PREFIX \
        -DBUILD_TESTING=OFF \
        -DBUILD_LIBSSL=OFF \
        -DBUILD_TOOL=OFF \
        -DCMAKE_OSX_ARCHITECTURES=aarch64 \
        ../aws-lc-${AWS_LC_VER} && \
    ninja install

/bin/sh: 1: ninja-build: not found despite apt installing ninja-build

is there under different name:

 > [ 8/15] RUN dpkg-query -L ninja-build && false:
0.085 /.
0.085 /usr
0.085 /usr/bin
0.085 /usr/bin/ninja
0.085 /usr/share
0.085 /usr/share/bash-completion
0.085 /usr/share/bash-completion/completions
0.085 /usr/share/bash-completion/completions/ninja
0.085 /usr/share/doc
0.085 /usr/share/doc/ninja-build
0.085 /usr/share/doc/ninja-build/changelog.Debian.gz
0.085 /usr/share/doc/ninja-build/copyright
0.085 /usr/share/doc/ninja-build/manual.html
0.085 /usr/share/doc-base
0.085 /usr/share/doc-base/ninja-build.ninja-build-manual
0.085 /usr/share/emacs
0.085 /usr/share/emacs/site-lisp
0.085 /usr/share/emacs/site-lisp/ninja-mode.el
0.085 /usr/share/man
0.085 /usr/share/man/man1
0.085 /usr/share/man/man1/ninja.1.gz
0.085 /usr/share/vim
0.085 /usr/share/vim/addons
0.085 /usr/share/vim/addons/syntax
0.085 /usr/share/vim/addons/syntax/ninja.vim
0.085 /usr/share/zsh
0.085 /usr/share/zsh/vendor-completions
0.085 /usr/share/zsh/vendor-completions/_ninja

using ninja over ninja-build.

/usr/bin/ld: cannot find -lgcc_s: No such file or directory

avoided by not doing any linking in the build (turning off tool, libssl build and test builds)

dropping go dep

seems to be a build time dep that we can drop according to

https://github.com/aws/aws-lc/blob/dc3b44be65ac29fc1999ab2aad2d06c64f7525b6/BUILDING.md?plain=1#L217-L225

didn't try.

clux added 3 commits February 25, 2025 18:34
WIP. not building yet.

Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
@clux clux changed the title aws-lc support WIP aws-lc tests Feb 25, 2025
@clux clux marked this pull request as ready for review February 26, 2025 00:17
@clux clux merged commit ca99f4c into main Feb 26, 2025
6 checks passed
@clux clux deleted the aws-lc-rs branch February 26, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support aws-lc for default rustls
1 participant